Skip to content

CONSOLE-4725: Update User Management list pages to use ResourceDataView #15579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 22, 2025
Merged

CONSOLE-4725: Update User Management list pages to use ResourceDataView #15579

openshift-merge-bot merged 1 commit into from
Oct 22, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 7, 2025 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Includes changes from #15492, #15560, and #15567 which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
@rhamilto rhamilto changed the title [WIP] CONSOLE-4725: Update User Management nav section to use ResourceDataView [WIP] CONSOLE-4725: Update User Management list pages to use ResourceDataView Oct 7, 2025
@openshift-ci openshift-ci bot requested review from Leo6Leo and spadgett October 7, 2025 18:14
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 7, 2025
@rhamilto rhamilto force-pushed the CONSOLE-4725 branch 2 times, most recently from 01eab09 to 2ec915f Compare October 8, 2025 12:21
@rhamilto
Copy link
Member Author

rhamilto commented Oct 8, 2025

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Oct 9, 2025

/retest

@rhamilto rhamilto force-pushed the CONSOLE-4725 branch 2 times, most recently from c95bc12 to 0b74c46 Compare October 9, 2025 17:03
@rhamilto
Copy link
Member Author

rhamilto commented Oct 9, 2025

/test backend

@rhamilto
Copy link
Member Author

rhamilto commented Oct 9, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 14, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto changed the title [WIP] CONSOLE-4725: Update User Management list pages to use ResourceDataView CONSOLE-4725: Update User Management list pages to use ResourceDataView Oct 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 17, 2025

Adding labels as this is more of the same table migration work that has previously been approved.
/label docs-approved
/label px-approved

/assign @logonoff
/assign @yapei

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 17, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 18, 2025

/retest

5 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/retest

@XiyunZhao
Copy link
Contributor

XiyunZhao commented Oct 21, 2025

/verified by @XiyunZhao
No issues were found during regression testing, and the AC has been achieved

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

@XiyunZhao: This PR has been marked as verified by @XiyunZhao.

Details

In response to this:

/verified by @XiyunZhao
No issues were found during regression testing, and the AC has been achieved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/retest

@logonoff
Copy link
Member

logonoff commented Oct 21, 2025

/cc

@openshift-ci openshift-ci bot requested a review from logonoff October 21, 2025 12:28
logonoff
logonoff reviewed Oct 21, 2025
View reviewed changes
logonoff
logonoff reviewed Oct 21, 2025
View reviewed changes
frontend/public/components/service-account.jsx
@@ -1,54 +1,79 @@
import { css } from '@patternfly/react-styles';
import { sortable } from '@patternfly/react-table';
import * as React from 'react';
Copy link
Member

@logonoff logonoff Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new code should avoid the React namepace import

Copy link
Member Author

@rhamilto rhamilto Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vojtechszocs, mind addressing this when you rebase #15622?

logonoff
logonoff reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it locally and found no issues

frontend/public/components/user.tsx
virtualize
/>
<React.Suspense fallback={<LoadingBox />}>
<ResourceDataView
Copy link
Member

@logonoff logonoff Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ResourceDataView
<ResourceDataView<UserKind>

Copy link
Member Author

@rhamilto rhamilto Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to get updated once #15622 merges, so let's punt for now.

Copy link
Member Author

@rhamilto rhamilto Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vojtechszocs, mind addressing this when you rebase #15622?

@logonoff
Copy link
Member

logonoff commented Oct 21, 2025

let's just deal with these as a follow ons

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2025

/retest-required

Remaining retests: 0 against base HEAD dd8daa7 and 2 for PR HEAD c7e2c3c in total

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit 83edfd9 into openshift:main Oct 22, 2025
7 of 8 checks passed
@rhamilto rhamilto deleted the CONSOLE-4725 branch October 22, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@spadgett spadgett Awaiting requested review from spadgett

1 more reviewer

@logonoff logonoff logonoff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yapei yapei

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @XiyunZhao @logonoff @yapei