Skip to content

CONSOLE-4838: Make DataView component work with arbitrary data objects #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Oct 25, 2025
Merged

CONSOLE-4838: Make DataView component work with arbitrary data objects #15622

openshift-merge-bot merged 3 commits into from
Oct 25, 2025

Conversation

@vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Oct 17, 2025 •
edited
Loading

  • Rename ResourceDataView to ConsoleDataView and update related code
  • Remove assumption that data items must always be k8s resource objects
  • Provide optional getObjectMetadata prop for working with non-k8s data items

@vojtechszocs vojtechszocs changed the title Make DataView component work with arbitrary data objects CONSOLE-4838: Make DataView component work with arbitrary data objects Oct 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@vojtechszocs: This pull request references CONSOLE-4838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and rhamilto October 17, 2025 19:56
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@vojtechszocs: This pull request references CONSOLE-4838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Rename ResourceDataView to ConsoleDataView and update related code
  • Remove assumption that ConsoleDataView component's data should be K8sResourceCommon compatible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff
logonoff reviewed Oct 17, 2025
View reviewed changes
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2025 •
edited by openshift-ci bot
Loading

@vojtechszocs: This pull request references CONSOLE-4838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Rename ResourceDataView to ConsoleDataView and update related code
  • Remove assumption that data items must always be k8s resource objects
  • If data items are not k8s resources, use getResourceMetadata prop to provide relevant metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2025 •
edited by openshift-ci bot
Loading

@vojtechszocs: This pull request references CONSOLE-4838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Rename ResourceDataView to ConsoleDataView and update related code
  • Remove assumption that data items must always be k8s resource objects
  • Provide optional getObjectName prop for working with non-k8s data items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

rhamilto commented Oct 21, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 21, 2025
Merged
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Oct 21, 2025
logonoff
logonoff approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@logonoff
Copy link
Member

logonoff commented Oct 21, 2025

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 21, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@rhamilto rhamilto mentioned this pull request Oct 21, 2025
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025 •
edited by openshift-ci bot
Loading

@vojtechszocs: This pull request references CONSOLE-4838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Rename ResourceDataView to ConsoleDataView and update related code
  • Remove assumption that data items must always be k8s resource objects
  • Provide optional getObjectMetadata prop for working with non-k8s data items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Oct 21, 2025
@rhamilto
Copy link
Member

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

1 similar comment
@rhamilto
Copy link
Member

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member

rhamilto commented Oct 22, 2025 •
edited
Loading

@vojtechszocs, mind adding these fixes for CONSOLE-4725 when you rebase?

CONSOLE-4725-fixes.patch

(Edited to fix errant patch)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@rhamilto rhamilto mentioned this pull request Oct 22, 2025
Closed
@logonoff
Copy link
Member

logonoff commented Oct 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@logonoff
Copy link
Member

logonoff commented Oct 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member

rhamilto commented Oct 23, 2025

/test okd-scos-e2e-aws-ovn

@vojtechszocs
Copy link
Contributor Author

vojtechszocs commented Oct 23, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 24, 2025

verified the changes in #15567
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

verified the changes in #15567
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 6b4a6d8 and 2 for PR HEAD eb356f7 in total

@rhamilto
Copy link
Member

rhamilto commented Oct 24, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 7114853 and 1 for PR HEAD eb356f7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@vojtechszocs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn eb356f7 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1656e49 into openshift:main Oct 25, 2025
7 of 8 checks passed
@logonoff logonoff deleted the console-data-view branch October 25, 2025 01:06
@rhamilto
Copy link
Member

rhamilto commented Oct 25, 2025

/test okd-scos-e2e-aws-ovn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cajieh cajieh Awaiting requested review from cajieh

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yapei yapei

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vojtechszocs @openshift-ci-robot @rhamilto @logonoff @yapei