CONSOLE-4719: Update Home nav section pages to use DataView #15564

krishagarwal278 · 2025-10-03T20:47:45Z

Updated Page/s:

api-explorer.tsx
namespace.jsx
alert-manager.tsx
alertmanager-config.tsx

Home_listpages_dataView.mp4

openshift-ci-robot · 2025-10-03T20:47:49Z

@krishagarwal278: This pull request references CONSOLE-4719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Updated Page/s:

api-explorer.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-03T20:48:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-10-08T19:16:58Z

@krishagarwal278: This pull request references CONSOLE-4719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Updated Page/s:

api-explorer.tsx

namespace.jsx

alert-manager.tsx

alertmanager-config.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-08T19:21:27Z

@krishagarwal278: This pull request references CONSOLE-4719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Updated Page/s:

api-explorer.tsx

namespace.jsx

alert-manager.tsx

alertmanager-config.tsx

Home_listpages_dataView.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2025-10-08T19:24:12Z

/jira refresh

openshift-ci-robot · 2025-10-08T19:24:16Z

@krishagarwal278: This pull request references CONSOLE-4719 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2025-10-09T13:05:58Z

/retest

krishagarwal278 · 2025-10-20T04:33:57Z

/retest

krishagarwal278 · 2025-10-20T15:28:08Z

/test e2e-gcp-console

krishagarwal278 · 2025-10-20T18:28:08Z

/retest

krishagarwal278 · 2025-10-21T02:18:42Z

/retest

krishagarwal278 · 2025-10-22T02:44:33Z

/retest

rhamilto · 2025-10-23T12:21:30Z

frontend/public/components/api-explorer.tsx

-
  return (
    <PaneBody>
-      <Toolbar className="pf-m-toggle-group-container">


We should probably preserve the existing toolbar since it's custom.

rhamilto · 2025-10-23T12:25:12Z

frontend/public/components/factory/list-page.tsx

      hideLabelFilter={hideLabelFilter}
      columnLayout={columnLayout}
      uniqueFilterName={name}
+      omitFilterToolbar={omitFilterToolbar}


Why is this necessary? Filter is not output is omitFilterToolbar is true.

reverted changes to as seen on main

rhamilto · 2025-10-23T12:27:30Z

frontend/public/components/monitoring/alertmanager/alertmanager-config.tsx

 import { PageHeading } from '@console/shared/src/components/heading/PageHeading';
-import { Link, useNavigate } from 'react-router-dom-v5-compat';
-import { sortable } from '@patternfly/react-table';
+import { Link, useNavigate, useSearchParams } from 'react-router-dom-v5-compat';


This duplicates changes in https://github.com/openshift/console/pull/15567/files#diff-233daa6ff19c703186a86d5e133997c19d1aa5083978daaa8e49f370cff80756, so #15567 should merge first.

rhamilto · 2025-10-23T12:36:16Z

frontend/public/components/api-explorer.tsx

    return apiGroup ? result.add(apiGroup) : result;
  }, new Set<string>());
  const sortedGroups: string[] = [...groups].sort();
-  const groupOptions = sortedGroups.reduce(


Why are you removing all this custom sort code?

rhamilto · 2025-10-23T12:36:41Z

frontend/public/components/api-explorer.tsx

+        },
+      },
+      [TableColumnInfo[4].id]: {
+        cell: <div className="co-line-clamp">{getResourceDescription(model)}</div>,


This cell is empty. Make sure you verify the changes in the browser.

rhamilto · 2025-10-23T12:39:32Z

frontend/public/components/namespace.jsx

 };
 NamespacesTableHeader.displayName = 'NamespacesTableHeader';

-const NamespacesColumnManagementID = referenceForModel(NamespaceModel);


Still needed as we want to maintain all functionality including column management.

rhamilto · 2025-10-23T12:42:14Z

frontend/public/components/namespace.jsx

There are a number of issues here. Please double check. And note there are actually two different tables in this file. One for namespaces and one for projects. Both need to be updated.

rhamilto · 2025-10-23T14:37:07Z

frontend/public/components/api-explorer.tsx

This is a list of k8sResources, but it doesn't meet the conventions of our DataView implementation (the first column is not Name). Will need a custom implementation.

modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/alertmanager.cy.ts modified: frontend/packages/integration-tests-cypress/tests/crud/other-routes.cy.ts modified: frontend/packages/integration-tests-cypress/views/alertmanager.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/alert-manager.tsx modified: frontend/public/components/api-explorer.tsx modified: frontend/public/components/monitoring/alertmanager/alertmanager-config.tsx

modified: frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/alertmanager.cy.ts modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/receivers/email.cy.ts modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/receivers/pagerduty.cy.ts modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/receivers/slack.cy.ts modified: frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager/receivers/webhook.cy.ts modified: frontend/packages/integration-tests-cypress/views/alertmanager.ts modified: frontend/packages/integration-tests-cypress/views/list-page.ts modified: frontend/public/components/monitoring/alertmanager/alertmanager-config.tsx modified: frontend/public/locales/en/public.json

…test-fix modified: frontend/packages/console-app/src/components/data-view/useConsoleDataViewData.tsx modified: frontend/packages/console-app/src/components/data-view/useConsoleDataViewFilters.ts modified: frontend/packages/integration-tests-cypress/tests/crud/other-routes.cy.ts modified: frontend/public/components/namespace.jsx modified: frontend/public/locales/en/public.json

krishagarwal278 · 2025-10-28T13:04:08Z

/retest

krishagarwal278 · 2025-10-28T13:16:13Z

/retest

krishagarwal278 · 2025-10-28T13:48:24Z

/retest

openshift-ci · 2025-10-28T16:42:11Z

@krishagarwal278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`20942b7`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2025-10-29T15:46:03Z

Replaced by #15656

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025

openshift-ci bot requested review from sg00dwin and spadgett October 3, 2025 20:48

openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 3, 2025

krishagarwal278 marked this pull request as draft October 3, 2025 21:05

openshift-ci bot added component/monitoring Related to monitoring kind/cypress Related to Cypress e2e integration testing labels Oct 7, 2025

krishagarwal278 marked this pull request as ready for review October 7, 2025 20:46

openshift-ci bot requested review from jhadvig and kyoto October 7, 2025 20:47

krishagarwal278 changed the title ~~[WIP] CONSOLE-4719: Update Home nav section pages to use DataView~~ CONSOLE-4719: Update Home nav section pages to use DataView Oct 8, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025

krishagarwal278 force-pushed the CONSOLE-4719 branch 2 times, most recently from fec76e0 to 710b16a Compare October 18, 2025 00:39

krishagarwal278 force-pushed the CONSOLE-4719 branch 2 times, most recently from 89329a5 to 4042610 Compare October 20, 2025 17:58

rhamilto reviewed Oct 23, 2025

View reviewed changes

krishagarwal278 force-pushed the CONSOLE-4719 branch from d47624f to c382ffd Compare October 23, 2025 14:22

rhamilto reviewed Oct 23, 2025

View reviewed changes

openshift-ci bot added the component/dev-console Related to dev-console label Oct 23, 2025

krishagarwal278 force-pushed the CONSOLE-4719 branch 2 times, most recently from b16ee31 to 5cc3b04 Compare October 28, 2025 00:28

krishagarwal278 added 7 commits October 27, 2025 20:47

Updated API-explorer page to use ResourceDataView

6061acf

Updated namespace.jsx to use ResourceDataView

fbc5e19

integration test fixes

63d25fb

Fixed kebab dropdown on alertmanager list page

add7522

krishagarwal278 force-pushed the CONSOLE-4719 branch from 5cc3b04 to 062826d Compare October 28, 2025 00:47

Addressed PR reviews

1232b01

krishagarwal278 force-pushed the CONSOLE-4719 branch from 062826d to 1232b01 Compare October 28, 2025 02:03

Reverted repeating changes

20942b7

rhamilto mentioned this pull request Oct 29, 2025

CONSOLE-4719: Update Home nav section pages to use DataView #15656

Merged

rhamilto closed this Oct 29, 2025

CONSOLE-4719: Update Home nav section pages to use DataView #15564

CONSOLE-4719: Update Home nav section pages to use DataView #15564

Uh oh!

Conversation

krishagarwal278 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 3, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 3, 2025

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Oct 8, 2025

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Oct 9, 2025

Uh oh!

krishagarwal278 commented Oct 20, 2025

Uh oh!

krishagarwal278 commented Oct 20, 2025

Uh oh!

krishagarwal278 commented Oct 20, 2025

Uh oh!

krishagarwal278 commented Oct 21, 2025

Uh oh!

krishagarwal278 commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krishagarwal278 commented Oct 28, 2025

Uh oh!

krishagarwal278 commented Oct 28, 2025

Uh oh!

krishagarwal278 commented Oct 28, 2025

Uh oh!

openshift-ci bot commented Oct 28, 2025

Uh oh!

rhamilto commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

krishagarwal278 commented Oct 3, 2025 •

edited

Loading

openshift-ci-robot commented Oct 3, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading