Skip to content

CONSOLE-4719: Update Home nav section pages to use DataView #15656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Nov 6, 2025
Merged

CONSOLE-4719: Update Home nav section pages to use DataView #15656

openshift-merge-bot merged 3 commits into from
Nov 6, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 29, 2025

Includes changes from #15651, which should merge first.

Replaces #15564

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4719 which is a valid jira issue.

Details

In response to this:

Includes changes from #15651, which should merge first.

Replaces #15564

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto mentioned this pull request Oct 29, 2025
Closed
@openshift-ci openshift-ci bot requested review from Leo6Leo and TheRealJon October 29, 2025 15:46
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 29, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

Adding labels as this is more of the same table migration work that has previously been approved.
/label docs-approved
/label px-approved

/assign @jhadvig
/assign @yapei

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 29, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 29, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025 •
edited
Loading

  • performed some testing about Projects list, Namespaces list, AlertManager config page

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

/retest-required

logonoff
logonoff reviewed Oct 31, 2025
View reviewed changes
frontend/public/components/alert-manager.tsx
} from '@patternfly/react-core';
import { PencilAltIcon } from '@patternfly/react-icons/dist/esm/icons/pencil-alt-icon';

import { DASH } from '@console/shared';
Copy link
Member

@logonoff logonoff Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using the root @console/shared import because there is a high probability of import cycles

Suggested change
import { DASH } from '@console/shared';
import { DASH } from '@console/shared/src/constants/ui'

frontend/public/components/namespace.jsx
@@ -1,9 +1,9 @@
/* eslint-disable tsdoc/syntax */
import * as React from 'react';
Copy link
Member

@logonoff logonoff Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use namespace react import in new code

frontend/public/components/namespace.jsx
REQUESTER_FILTER,
useFlag,
usePrometheusGate,
DASH,
Copy link
Member

@logonoff logonoff Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this imported separately to reduce dependence of the @console/shared root barrel

@logonoff
Copy link
Member

logonoff commented Oct 31, 2025

Since these are simple fixes, I'm going to LGTM this, so we can follow up later

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2025

/retest-required

Remaining retests: 0 against base HEAD e6898b5 and 2 for PR HEAD 8665b5f in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 1, 2025

/retest-required

Remaining retests: 0 against base HEAD bed7e7c and 1 for PR HEAD 8665b5f in total

@logonoff
Copy link
Member

logonoff commented Nov 3, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025

/retest-required

Remaining retests: 0 against base HEAD 137d125 and 0 for PR HEAD 8665b5f in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025

/hold

Revision 8665b5f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025
@jhadvig
Copy link
Member

jhadvig commented Nov 5, 2025 •
edited
Loading

/hold cancel

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c8d3ac2 into openshift:main Nov 6, 2025
8 checks passed
@logonoff logonoff deleted the CONSOLE-4719 branch November 6, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

1 more reviewer

@logonoff logonoff logonoff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhadvig jhadvig

@yapei yapei

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @yapei @logonoff @jhadvig