Skip to content

NO-JIRA: reintroduce load bearing import cycles #15651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Oct 31, 2025
Merged

NO-JIRA: reintroduce load bearing import cycles #15651

openshift-merge-bot merged 2 commits into from
Oct 31, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Oct 28, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from Leo6Leo and jhadvig October 28, 2025 13:35
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2025
@logonoff logonoff force-pushed the asdasd branch 2 times, most recently from b93010e to 3edf1b5 Compare October 28, 2025 13:37
@logonoff logonoff changed the title reintroduce load bearing console-app imports NO-JIRA: reintroduce load bearing console-app imports Oct 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology labels Oct 28, 2025
@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 28, 2025
@rhamilto rhamilto mentioned this pull request Oct 28, 2025
Merged
@logonoff logonoff changed the title NO-JIRA: reintroduce load bearing console-app imports NO-JIRA: reintroduce load bearing import cycles Oct 28, 2025
@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

tested in dev mode

/verified by @logonoff @rhamilto

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

@logonoff: This PR has been marked as verified by @logonoff @rhamilto.

Details

In response to this:

tested in dev mode

/verified by @logonoff @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

rhamilto commented Oct 28, 2025

/lgtm
/verified by @rhamilto

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

@rhamilto: This PR has been marked as verified by @rhamilto.

Details

In response to this:

/lgtm
/verified by @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

/retest-required

Remaining retests: 0 against base HEAD d3f9db4 and 2 for PR HEAD 2f53904 in total

This was referenced Oct 28, 2025
Merged
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

/retest-required

Remaining retests: 0 against base HEAD 38fa442 and 1 for PR HEAD 2f53904 in total

@logonoff
Copy link
Member Author

logonoff commented Oct 29, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 1e2f633 and 0 for PR HEAD 2f53904 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a5e8fe9 into openshift:main Oct 31, 2025
8 checks passed
@logonoff logonoff deleted the asdasd branch October 31, 2025 12:28
@jhadvig jhadvig mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR hacktoberfest-accepted jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@logonoff @openshift-ci-robot @rhamilto @jhadvig