Skip to content

CONSOLE-4721: Update Helm nav section to use ConsoleDataView #15646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 6, 2025
Merged

CONSOLE-4721: Update Helm nav section to use ConsoleDataView #15646

openshift-merge-bot merged 1 commit into from
Nov 6, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 27, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 27, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4721 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/helm Related to helm-plugin component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 27, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 27, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@rhamilto rhamilto changed the title [WIP] CONSOLE-4721: Update Helm nav section to use ConsoleDataView CONSOLE-4721: Update Helm nav section to use ConsoleDataView Oct 28, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

Adding labels as this is more of the same table migration work that has previously been approved.
/label docs-approved
/label px-approved

/assign @vikram-raj
/assign @yapei

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 28, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 28, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

performed testing on these pages

  • Helm -> Repositories list, including HelmChartRepository and ProjectHelmChartRepository
Screenshot 2025-10-30 at 3 57 28 PM
  • Helm -> Releases list, Resources and Revision history tab, HelmReleases Rollback form
Screenshot 2025-10-30 at 4 11 16 PM Screenshot 2025-10-30 at 4 11 07 PM Screenshot 2025-10-30 at 4 03 40 PM

No regression issues found
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

performed testing on these pages

  • Helm -> Repositories list, including HelmChartRepository and ProjectHelmChartRepository
Screenshot 2025-10-30 at 3 57 28 PM
  • Helm -> Releases list, Resources and Revision history tab, HelmReleases Rollback form
Screenshot 2025-10-30 at 4 11 16 PM Screenshot 2025-10-30 at 4 11 07 PM Screenshot 2025-10-30 at 4 03 40 PM

No regression issues found
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025

/retest-required

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025 •
edited
Loading

one question, how can we confirm whether the e2e test changes regarding to frontend/packages/helm-plugin/integration-tests/xxxxx files are passing or not in CI? I didn't see tests for helm plugin are triggered in e2e-gcp-console ... Am I checking the right place?

@yapei
Copy link
Contributor

yapei commented Oct 30, 2025 •
edited
Loading

it seems like webterminal tests failed and then test-prow-e2e.sh quit prematurely, that's why helm-plugin tests are not triggered, is it correct?

@vikram-raj
Copy link
Member

vikram-raj commented Nov 3, 2025

@yapei Ye do have Helm tests in CI, and it is not getting triggered as other tests failed before it gets triggered.

@vikram-raj
Copy link
Member

vikram-raj commented Nov 3, 2025

/retest

vikram-raj
vikram-raj reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025

/retest-required

Remaining retests: 0 against base HEAD 89245b3 and 2 for PR HEAD 78e3a1d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025

/retest-required

Remaining retests: 0 against base HEAD d463f59 and 1 for PR HEAD 78e3a1d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025

/retest-required

Remaining retests: 0 against base HEAD 705c494 and 0 for PR HEAD 78e3a1d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025

/hold

Revision 78e3a1d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@jhadvig
Copy link
Member

jhadvig commented Nov 5, 2025

#15651 got merged
/hold cancel

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6d11891 into openshift:main Nov 6, 2025
7 of 8 checks passed
@rhamilto rhamilto deleted the CONSOLE-4721 branch November 6, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishagarwal278 krishagarwal278 Awaiting requested review from krishagarwal278

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

1 more reviewer

@vikram-raj vikram-raj vikram-raj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vikram-raj vikram-raj

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @openshift-ci-robot @yapei @vikram-raj @jhadvig @openshift-merge-robot