Skip to content

Convert deployment components to TypeScript #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 13, 2019
Merged

Convert deployment components to TypeScript #1555

openshift-merge-robot merged 1 commit into from
May 13, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented May 9, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2019
@spadgett spadgett force-pushed the deployments-typescript branch from 8bc8eca to 4279609 Compare May 9, 2019 22:28
@spadgett spadgett added this to the v4.2 milestone May 9, 2019
jhadvig
jhadvig reviewed May 10, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thought, otherwise looks like a merge 👍

frontend/public/components/deployment.tsx Outdated
Copy link
Member

@jhadvig jhadvig May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's declare DeploymentsReference and use that here and below ?

const DeploymentsReference: K8sResourceKindReference = 'Deployment';

@spadgett spadgett force-pushed the deployments-typescript branch from 4279609 to 708a840 Compare May 10, 2019 16:23
@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

@jhadvig thanks, updated

@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

8 similar comments
@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 10, 2019

/retest

@jhadvig
Copy link
Member

jhadvig commented May 11, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 11, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented May 11, 2019

/retest

jhadvig
jhadvig approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change locally and looks good 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented May 13, 2019

ENOMEM: not enough memory, write

openshift/release#3749

/test frontend

@openshift-merge-robot openshift-merge-robot merged commit 072e8b0 into openshift:master-next May 13, 2019
@spadgett spadgett deleted the deployments-typescript branch May 13, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @jhadvig @openshift-ci-robot @openshift-bot @openshift-merge-robot