Skip to content

Increase memory limit for console build #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 13, 2019
Merged

Increase memory limit for console build #3749

openshift-merge-robot merged 1 commit into from
May 13, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented May 10, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2019
jcaianirh
jcaianirh approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spadgett spadgett mentioned this pull request May 13, 2019
Merged
@spadgett
Copy link
Member Author

spadgett commented May 13, 2019

lgtm

@jcaianirh can you /lgtm? :)

@jcaianirh
Copy link
Member

jcaianirh commented May 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 282d260 into openshift:master May 13, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2019

@spadgett: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
Details

In response to this:

We're seeing more ENOMEM failures, 16 results in the past week.

https://search.svc.ci.openshift.org/?search=ENOMEM&maxAge=168h&context=2&type=all

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_console/1555/pull-ci-openshift-console-master-frontend/3868

Previous PR #2805

/assign @jcaianirh
@rhamilto fyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the increase-console-memory-limit branch July 18, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petr-muller petr-muller Awaiting requested review from petr-muller

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

1 more reviewer

@jcaianirh jcaianirh jcaianirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcaianirh jcaianirh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @jcaianirh @openshift-ci-robot @openshift-merge-robot