Skip to content

OCPBUGS-61660: Fix Bare Metal Hosts nav item #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 17, 2025
Merged

OCPBUGS-61660: Fix Bare Metal Hosts nav item #15609

openshift-merge-bot merged 1 commit into from
Oct 17, 2025

Conversation

@vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Oct 15, 2025

image

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 15, 2025

@vikram-raj: This pull request references Jira Issue OCPBUGS-61660, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig, rawagner and yapei October 15, 2025 14:57
@openshift-ci openshift-ci bot added component/metal3 Related to metal3-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2025
logonoff
logonoff suggested changes Oct 16, 2025
View reviewed changes
logonoff
logonoff approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As a follow on we should convert the rest of plugin.tsx over to console-extensions.json

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

krishagarwal278
krishagarwal278 reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@krishagarwal278 krishagarwal278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

...ges/metal3-plugin/src/components/baremetal-hosts/add-baremetal-host/AddBareMetalHostPage.tsx
import AddBareMetalHost from './AddBareMetalHost';

const AddBareMetalHostPage: React.FunctionComponent = () => {
const AddBareMetalHostPage: React.FC = () => {
Copy link
Member

@krishagarwal278 krishagarwal278 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this as FCC instead?

@logonoff
Copy link
Member

logonoff commented Oct 16, 2025

/verified later @yanpzhan

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2025

@logonoff: This PR has been marked to be verified later by @yanpzhan.

Details

In response to this:

/verified later @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 4290cf0 and 2 for PR HEAD 4869959 in total

@logonoff logonoff mentioned this pull request Oct 16, 2025
Merged
@logonoff
Copy link
Member

logonoff commented Oct 16, 2025

/retest

1 similar comment
@logonoff
Copy link
Member

logonoff commented Oct 17, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 694efdb and 1 for PR HEAD 4869959 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 864834c into openshift:main Oct 17, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025

@vikram-raj: Jira Issue OCPBUGS-61660: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-61660 has been moved to the MODIFIED state.

Details

In response to this:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2025

Fix included in accepted release 4.21.0-0.nightly-2025-10-18-225958

@vikram-raj vikram-raj deleted the ocpbugs-61660 branch October 22, 2025 10:32
@vikram-raj
Copy link
Member Author

vikram-raj commented Oct 22, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 22, 2025

@vikram-raj: new pull request created: #15628

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yapei yapei Awaiting requested review from yapei

@jhadvig jhadvig Awaiting requested review from jhadvig

@rawagner rawagner Awaiting requested review from rawagner

2 more reviewers

@krishagarwal278 krishagarwal278 krishagarwal278 left review comments

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/metal3 Related to metal3-plugin jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vikram-raj @openshift-ci-robot @logonoff @openshift-merge-robot @openshift-cherrypick-robot @krishagarwal278