Skip to content

CONSOLE-4835: Migrate topology to dynamic #15617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Oct 31, 2025
Merged

CONSOLE-4835: Migrate topology to dynamic #15617

openshift-merge-bot merged 3 commits into from
Oct 31, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Oct 16, 2025

Also introduce console.model-metadata to replace removed-and-not-migrated ModelDefinition extensions in olmv0 and container-security. Thanks @vikram-raj for using them in #15609!

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Also introduce console.model-metadata to replace removed-and-not-migrated ModelDefinition extensions in olmv0 and container-security. Thanks @vikram-raj for using them in #15609!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and sg00dwin October 16, 2025 19:49
@openshift-ci openshift-ci bot added component/olm Related to OLM component/topology Related to topology approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 16, 2025
@logonoff
Copy link
Member Author

logonoff commented Oct 16, 2025

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 16, 2025
@logonoff logonoff force-pushed the CONSOLE-4835-s2e6-the-fight branch 2 times, most recently from ff72620 to dc8cc71 Compare October 17, 2025 14:28
@logonoff logonoff force-pushed the CONSOLE-4835-s2e6-the-fight branch from dc8cc71 to a44ea00 Compare October 23, 2025 04:36
@logonoff
Copy link
Member Author

logonoff commented Oct 23, 2025

/assign @yapei @vikram-raj @vojtechszocs

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanpzhan
Copy link
Contributor

yanpzhan commented Oct 28, 2025

Regression test about topology/olm related pages passed.
/verified by @yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

@yanpzhan: This PR has been marked as verified by @yanpzhan.

Details

In response to this:

Regression test about topology/olm related pages passed.
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2025

/retest-required

Remaining retests: 0 against base HEAD d3f9db4 and 2 for PR HEAD a44ea00 in total

@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/retest

1 similar comment
@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/retest

@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/retest

@logonoff logonoff mentioned this pull request Oct 28, 2025
Merged
@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/retest

2 similar comments
@logonoff
Copy link
Member Author

logonoff commented Oct 28, 2025

/retest

@logonoff
Copy link
Member Author

logonoff commented Oct 29, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

/retest-required

Remaining retests: 0 against base HEAD 38fa442 and 1 for PR HEAD a44ea00 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 1e2f633 and 0 for PR HEAD a44ea00 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e9ee127 into openshift:main Oct 31, 2025
8 checks passed
@logonoff logonoff deleted the CONSOLE-4835-s2e6-the-fight branch October 31, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

Assignees

@vojtechszocs vojtechszocs

@vikram-raj vikram-raj

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR hacktoberfest-accepted jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@logonoff @openshift-ci-robot @vojtechszocs @yanpzhan @jhadvig @vikram-raj @yapei