NO-JIRA: add claude `/plugin-api-review` command #15658

logonoff · 2025-10-29T18:29:16Z

example output from #15655

Plugin API Review Report

API change: Internal refactoring to always use canonical model references
JIRA issue: CONSOLE-4837
Current OpenShift version: 4.21
Changes to changelog made? N/A - No plugin API changes

Summary

The changes in this branch are internal console refactoring and do not affect the plugin API. The modified files are:

frontend/public/components/utils/resource-link.tsx - Simplified to always use referenceForModel() instead of conditionally using plural or referenceForModel based on CRD status
frontend/public/kinds.ts - Added new usePlural hook (hook version of connectToPlural) for internal console use

These files are not part of the @openshift-console/dynamic-plugin-sdk package and are not exported as shared modules or extension APIs. They are internal console implementation files in the frontend/public directory.

Findings

Reviewed changes for plugin API impact - No plugin API changes detected
Verified that the change does not need to be documented in the "Changes to plugin API" section of the dynamic plugin SDK release notes - not applicable
Verified that the change does not need to be documented in the "Changes to shared modules and API" section of the dynamic plugin SDK release notes - not applicable
Verified that the change does not need to be documented in the SDK core changelog - not applicable
Verified that the change does not need to be documented in the SDK webpack changelog - not applicable
Verified that no CSS class changes require documentation - no CSS files modified
Verified that a JIRA issue is associated with the change - CONSOLE-4837
Verified that the styleguide is followed for all changed files

Issues found during review

Code Quality Observations (not plugin API compliance issues):

In frontend/public/kinds.ts, the usePlural function calls buildK8sKind() with the result of modelMetadata.find() which can return undefined. This may cause runtime errors if no matching metadata is found.
Potential null reference in buildK8sKind where metadata.properties?.labelPlural.toLowerCase() doesn't use optional chaining on the .toLowerCase() call.

These are internal implementation issues and do not affect plugin API compliance.

Actions taken

None required - no plugin API changes to document.

Compliance score: 10/10

Reason for score:

All plugin API review criteria are satisfied
No plugin API changes were made, so no changelog documentation is required
JIRA issue (CONSOLE-4837) is properly associated with the changes
The styleguide is followed for all changed files
Changes are purely internal refactoring that do not affect dynamic plugins

openshift-ci-robot · 2025-10-29T18:29:21Z

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

example output from #15655

Plugin API Review Report

API change: Internal refactoring to always use canonical model references
JIRA issue: CONSOLE-4837
Current OpenShift version: 4.21
Changes to changelog made? N/A - No plugin API changes

Summary

The changes in this branch are internal console refactoring and do not affect the plugin API. The modified files are:

frontend/public/components/utils/resource-link.tsx - Simplified to always use referenceForModel() instead of conditionally using plural or referenceForModel based on CRD status

frontend/public/kinds.ts - Added new usePlural hook (hook version of connectToPlural) for internal console use

These files are not part of the @openshift-console/dynamic-plugin-sdk package and are not exported as shared modules or extension APIs. They are internal console implementation files in the frontend/public directory.

Findings

Reviewed changes for plugin API impact - No plugin API changes detected

Verified that the change does not need to be documented in the "Changes to plugin API" section of the dynamic plugin SDK release notes - not applicable

Verified that the change does not need to be documented in the "Changes to shared modules and API" section of the dynamic plugin SDK release notes - not applicable

Verified that the change does not need to be documented in the SDK core changelog - not applicable

Verified that the change does not need to be documented in the SDK webpack changelog - not applicable

Verified that no CSS class changes require documentation - no CSS files modified

Verified that a JIRA issue is associated with the change - CONSOLE-4837

Verified that the styleguide is followed for all changed files

Issues found during review

Code Quality Observations (not plugin API compliance issues):

In frontend/public/kinds.ts, the usePlural function calls buildK8sKind() with the result of modelMetadata.find() which can return undefined. This may cause runtime errors if no matching metadata is found.

Potential null reference in buildK8sKind where metadata.properties?.labelPlural.toLowerCase() doesn't use optional chaining on the .toLowerCase() call.

These are internal implementation issues and do not affect plugin API compliance.

Actions taken

None required - no plugin API changes to document.

Compliance score: 10/10

Reason for score:

All plugin API review criteria are satisfied

No plugin API changes were made, so no changelog documentation is required

JIRA issue (CONSOLE-4837) is properly associated with the changes

The styleguide is followed for all changed files

Changes are purely internal refactoring that do not affect dynamic plugins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-29T18:57:44Z

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/backend	`9452683`	link	true	`/test backend`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

logonoff · 2025-10-30T18:05:06Z

/verified bypass
/label px-approved
/label docs-approved

openshift-ci-robot · 2025-10-30T18:05:18Z

@logonoff: The verified label has been added.

Details

In response to this:

/verified bypass
/label px-approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-10-31T16:29:41Z

/meow

openshift-ci · 2025-10-31T16:29:44Z

@Leo6Leo:

Details

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

.claude/commands/plugin-api-review.md

dfdsf

spadgett

Nice, thanks! 👍

/lgtm

spadgett · 2025-11-14T16:01:47Z

.claude/commands/plugin-api-review.md

+- CSS classes may be inadvertently used by plugins, so changes to CSS files
+  should be reviewed for potential breakages. Perform a search on GitHub for
+  the class name to see if it is used in any public plugins. Repos which are
+  console dynamic plugins will always consume
+  `@openshift-console/dynamic-plugin-sdk` in the `package.json` file of the repo.


Nice. I assume this will not have false positives on public forks of the openshift/console repo?

I haven't had any problems with that yet

spadgett · 2025-11-14T16:05:00Z

.claude/commands/plugin-api-review.md

+- New API or extension points MUST be well documented with descriptions that are
+  clear enough to allow plugin authors to understand their purpose and usage without
+  referring back to the source code. Assume that plugin authors do not have
+  knowledge of the internal workings of OpenShift Console. New documentation SHOULD
+  contain examples of usage where applicable, edge cases and behavior when parameters
+  such as `null`, `undefined`, or invalid values are provided.


This is important, thank you

openshift-ci · 2025-11-14T16:06:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-11-14T16:07:55Z

/verified by @logonoff

openshift-ci-robot · 2025-11-14T16:08:08Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-14T16:10:08Z

/hold to avoid retesting #15679

logonoff · 2025-11-14T18:21:17Z

/unhold

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025

openshift-ci bot requested review from jhadvig and krishagarwal278 October 29, 2025 18:30

openshift-ci bot added the component/core Related to console core functionality label Oct 29, 2025

logonoff force-pushed the money branch from 9452683 to 1756168 Compare October 29, 2025 18:37

jhadvig added the hacktoberfest-accepted label Oct 30, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 30, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025

krishagarwal278 reviewed Nov 2, 2025

View reviewed changes

.claude/commands/plugin-api-review.md Outdated Show resolved Hide resolved

.claude/commands/plugin-api-review.md Show resolved Hide resolved

logonoff force-pushed the money branch from 1756168 to 0c76af9 Compare November 3, 2025 14:26

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 3, 2025

logonoff force-pushed the money branch 2 times, most recently from 3791f7e to b0bfd81 Compare November 10, 2025 20:33

logonoff mentioned this pull request Nov 10, 2025

CONSOLE-4840: Remove all plugin entry points + topology static extension cleanup #15699

Merged

logonoff force-pushed the money branch from b0bfd81 to 4a47669 Compare November 13, 2025 01:29

NO-JIRA: add claude /plugin-api-review command

1f395c0

dfdsf

logonoff force-pushed the money branch from 4a47669 to 1f395c0 Compare November 13, 2025 18:25

spadgett approved these changes Nov 14, 2025

View reviewed changes

openshift-ci bot assigned spadgett Nov 14, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 14, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025

openshift-merge-bot bot merged commit 040fe4e into openshift:main Nov 14, 2025
3 checks passed

logonoff deleted the money branch November 14, 2025 19:17

NO-JIRA: add claude /plugin-api-review command #15658

NO-JIRA: add claude /plugin-api-review command #15658

Uh oh!

Conversation

logonoff commented Oct 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plugin API Review Report

Summary

Findings

Issues found during review

Actions taken

Compliance score: 10/10

Uh oh!

openshift-ci-robot commented Oct 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plugin API Review Report

Summary

Findings

Issues found during review

Actions taken

Compliance score: 10/10

Uh oh!

openshift-ci bot commented Oct 29, 2025

Uh oh!

logonoff commented Oct 30, 2025

Uh oh!

openshift-ci-robot commented Oct 30, 2025

Uh oh!

Leo6Leo commented Oct 31, 2025

Uh oh!

openshift-ci bot commented Oct 31, 2025

Uh oh!

Uh oh!

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

spadgett Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 14, 2025

Uh oh!

logonoff commented Nov 14, 2025

Uh oh!

openshift-ci-robot commented Nov 14, 2025

Uh oh!

logonoff commented Nov 14, 2025

Uh oh!

logonoff commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NO-JIRA: add claude `/plugin-api-review` command #15658

NO-JIRA: add claude `/plugin-api-review` command #15658

logonoff commented Oct 29, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 29, 2025 •

edited by openshift-ci bot

Loading