CONSOLE-4840: Migrate GuidedTour to dynamic #15679

logonoff · 2025-11-05T13:30:43Z

Changes:

GuidedTour static extension removed
INTERNAL_DO_NOT_USE.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not a supported use-case

openshift-ci-robot · 2025-11-05T13:30:47Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.guided-tour dynamic extension introduced

Removed dev-console and console-app plugin.tsx. Load bearing imports are now present in frontend/public/plugin.ts where I will still need to remove them later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/packages/console-app/src/components/guided-tour/index.tsx

openshift-ci-robot · 2025-11-05T13:33:56Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not intended

Removed dev-console and console-app plugin.tsx. Load bearing imports are now present in frontend/public/plugin.ts where I will still need to remove them later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-05T13:38:54Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not a supported use-case

Removed dev-console and console-app plugin.tsx. Load bearing imports are now present in frontend/public/plugin.ts where I will still need to remove them later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/webpack.config.ts

frontend/public/plugins.ts

logonoff · 2025-11-06T13:51:05Z

/label px-approved
/label docs-approved

openshift-ci-robot · 2025-11-06T13:51:29Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not a supported use-case

Removed dev-console and console-app plugin.tsx. Load bearing imports are now present in frontend/public/plugin.ts where I still need to remove them later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/packages/console-app/src/components/guided-tour/index.tsx

frontend/packages/console-app/console-extensions.json

frontend/webpack.config.ts

openshift-ci-robot · 2025-11-06T20:11:13Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

INTERNAL_DO_NOT_USE.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not a supported use-case

Removed dev-console and console-app plugin.tsx. Load bearing imports are now present in frontend/public/plugin.ts where I still need to remove them later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-13T01:52:29Z

just a rebase
/verified by yapei

openshift-ci-robot · 2025-11-13T01:52:41Z

@logonoff: This PR has been marked as verified by yapei.

Details

In response to this:

just a rebase
/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-13T18:18:59Z

/hold

let's wait for #15723

renamed extension to `INTERNAL_DO_NOT_USE.guided-tour` to discourage usage while we are discuss whether to keep the guided tour around

also move `guidedtour` to dynamic plugin sdk after some feedback. for consistency `useTranslatedExtensions` is a named export

logonoff · 2025-11-14T13:04:10Z

/unhold

logonoff · 2025-11-14T13:04:30Z

rebase with no functional changes

/verified by yapei

openshift-ci-robot · 2025-11-14T13:04:42Z

@logonoff: This PR has been marked as verified by yapei.

Details

In response to this:

rebase with no functional changes

/verified by yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

spadgett

/lgtm

spadgett · 2025-11-14T15:38:17Z

frontend/webpack.config.ts

  new CircularDependencyPreset({
    exclude: /node_modules|public\/dist|\.(gql|html)$/,
-    thresholds: { totalCycles: 21 }, // TODO(CONSOLE-4806): Set threshold to 0
+    thresholds: { totalCycles: 14 }, // TODO(CONSOLE-4806): Set threshold to 0


openshift-ci · 2025-11-14T15:38:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2025-11-14T15:39:13Z

/label plugin-api-approved

openshift-ci-robot · 2025-11-14T15:46:01Z

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Changes:

GuidedTour static extension removed

INTERNAL_DO_NOT_USE.guided-tour dynamic extension introduced. It can be used by dynamic plugins outside of the repo but the extension name makes it clear this is not a supported use-case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-14T18:29:51Z

/retest-required

Remaining retests: 0 against base HEAD d673d10 and 2 for PR HEAD 1208430 in total

openshift-ci · 2025-11-15T05:13:46Z

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`1208430`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025

openshift-ci bot requested review from TheRealJon and krishagarwal278 November 5, 2025 13:31

logonoff commented Nov 5, 2025

View reviewed changes

frontend/packages/console-app/src/components/guided-tour/index.tsx Outdated Show resolved Hide resolved

logonoff force-pushed the CONSOLE-4840-guided-tour branch from 568b37e to 53c9e9d Compare November 5, 2025 15:49

logonoff changed the title ~~[WIP] CONSOLE-4840: Migrate GuidedTour to dynamic~~ CONSOLE-4840: Migrate GuidedTour to dynamic Nov 5, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025

logonoff commented Nov 5, 2025

View reviewed changes

frontend/webpack.config.ts Outdated Show resolved Hide resolved

frontend/public/plugins.ts Outdated Show resolved Hide resolved

logonoff force-pushed the CONSOLE-4840-guided-tour branch 2 times, most recently from 9c8b186 to 2614061 Compare November 6, 2025 13:22

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 6, 2025

spadgett reviewed Nov 6, 2025

View reviewed changes

frontend/packages/console-app/src/components/guided-tour/index.tsx Outdated Show resolved Hide resolved

frontend/packages/console-app/console-extensions.json Outdated Show resolved Hide resolved

frontend/webpack.config.ts Outdated Show resolved Hide resolved

logonoff force-pushed the CONSOLE-4840-guided-tour branch from 2614061 to 734f1b1 Compare November 6, 2025 17:19

logonoff requested a review from spadgett November 6, 2025 17:23

logonoff force-pushed the CONSOLE-4840-guided-tour branch from 734f1b1 to 0ec6e7e Compare November 7, 2025 00:16

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025

logonoff force-pushed the CONSOLE-4840-guided-tour branch from 470036b to 684b626 Compare November 13, 2025 01:30

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025

logonoff force-pushed the CONSOLE-4840-guided-tour branch from 684b626 to b6542a5 Compare November 13, 2025 12:58

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025

logonoff mentioned this pull request Nov 13, 2025

CONSOLE-4858: Fix 27 cycles #15723

Merged

logonoff added 3 commits November 14, 2025 08:00

CONSOLE-4840: Update README to reflect removal of static plugin system

2a6f5a8

CONSOLE-4840: Migrate GuidedTour to dynamic

97ef632

renamed extension to `INTERNAL_DO_NOT_USE.guided-tour` to discourage usage while we are discuss whether to keep the guided tour around

CONSOLE-4840: Translation fixes to useTourValuesForContext

1208430

also move `guidedtour` to dynamic plugin sdk after some feedback. for consistency `useTranslatedExtensions` is a named export

logonoff force-pushed the CONSOLE-4840-guided-tour branch from b6542a5 to 1208430 Compare November 14, 2025 13:04

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 14, 2025

spadgett approved these changes Nov 14, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2025

openshift-ci bot added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Nov 14, 2025

logonoff mentioned this pull request Nov 14, 2025

NO-JIRA: add claude /plugin-api-review command #15658

Merged

openshift-merge-bot bot merged commit 645d5a6 into openshift:main Nov 15, 2025
6 of 8 checks passed

logonoff deleted the CONSOLE-4840-guided-tour branch November 15, 2025 13:08

CONSOLE-4840: Migrate GuidedTour to dynamic #15679

CONSOLE-4840: Migrate GuidedTour to dynamic #15679

Uh oh!

Conversation

logonoff commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logonoff commented Nov 6, 2025

Uh oh!

openshift-ci-robot commented Nov 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

logonoff commented Nov 14, 2025

Uh oh!

logonoff commented Nov 14, 2025

Uh oh!

openshift-ci-robot commented Nov 14, 2025

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 14, 2025

Uh oh!

spadgett commented Nov 14, 2025

Uh oh!

openshift-ci-robot commented Nov 14, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 14, 2025

Uh oh!

Uh oh!

openshift-ci bot commented Nov 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

logonoff commented Nov 5, 2025 •

edited

Loading

openshift-ci-robot commented Nov 5, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 5, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 5, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 14, 2025 •

edited by openshift-ci bot

Loading