CONSOLE-4858: Fix 27 cycles #15723

logonoff · 2025-11-13T15:57:14Z

Cycle count goes from 27 (main) to 0 (PR) cycles after applying the below diff. Hooray!

diff --git a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
index 2ccc0e5480..7c2c9852ad 100644
--- a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
+++ b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
@@ -58,7 +58,6 @@ export const getActivePluginsModule = (
       activePlugins.push({
         name: '${pkg.name}',
         extensions: [
-          ...require('${pkg.name}/${pkg.consolePlugin.entry}').default,
           ...${extensionHook(pkg)},
         ],
       });
@@ -88,8 +87,6 @@ export const loadActivePluginsForTestPurposes = (
     activePlugins.push({
       name: pkg.name,
       extensions: [
-        // eslint-disable-next-line @typescript-eslint/no-var-requires
-        ...require(`${pkg.name}/${pkg.consolePlugin.entry}`).default,
         ...extensionHook(pkg),
       ],
     });
diff --git a/frontend/webpack.config.ts b/frontend/webpack.config.ts
index 06c8f46b78..ef735a5876 100644
--- a/frontend/webpack.config.ts
+++ b/frontend/webpack.config.ts
@@ -340,10 +340,6 @@ const config: Configuration = {
 if (CHECK_CYCLES === 'true') {
   new CircularDependencyPreset({
     exclude: /node_modules|public\/dist|\.(gql|html)$/,
-    // TODO: investigate how to load the plugins registry asynchronously
-    filterModules: /^get-active-plugins\.js$/,
-    // TODO: Fix cycles unveiled by CONSOLE-4837, then remove the below line
-    thresholds: { totalCycles: 5 },
     reportFile: '.webpack-cycles',
   }).apply(config.plugins);
 }

openshift-ci-robot · 2025-11-13T15:57:18Z

@logonoff: This pull request references CONSOLE-4858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Cycle count goes from 27 (PR) to 0 (PR) cycles after applying the below diff. Hooray!

diff --git a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
index 2ccc0e5480..7c2c9852ad 100644
--- a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
+++ b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
@@ -58,7 +58,6 @@ export const getActivePluginsModule = (
      activePlugins.push({
        name: '${pkg.name}',
        extensions: [
-          ...require('${pkg.name}/${pkg.consolePlugin.entry}').default,
          ...${extensionHook(pkg)},
        ],
      });
@@ -88,8 +87,6 @@ export const loadActivePluginsForTestPurposes = (
    activePlugins.push({
      name: pkg.name,
      extensions: [
-        // eslint-disable-next-line @typescript-eslint/no-var-requires
-        ...require(`${pkg.name}/${pkg.consolePlugin.entry}`).default,
        ...extensionHook(pkg),
      ],
    });
diff --git a/frontend/webpack.config.ts b/frontend/webpack.config.ts
index 06c8f46b78..ef735a5876 100644
--- a/frontend/webpack.config.ts
+++ b/frontend/webpack.config.ts
@@ -340,10 +340,6 @@ const config: Configuration = {
if (CHECK_CYCLES === 'true') {
  new CircularDependencyPreset({
    exclude: /node_modules|public\/dist|\.(gql|html)$/,
-    // TODO: investigate how to load the plugins registry asynchronously
-    filterModules: /^get-active-plugins\.js$/,
-    // TODO: Fix cycles unveiled by CONSOLE-4837, then remove the below line
-    thresholds: { totalCycles: 5 },
    reportFile: '.webpack-cycles',
  }).apply(config.plugins);
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-13T15:57:56Z

/label px-approved
/label docs-approved

logonoff · 2025-11-13T16:19:22Z

/assign @yapei @rhamilto

openshift-ci-robot · 2025-11-13T16:26:01Z

@logonoff: This pull request references CONSOLE-4858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Cycle count goes from 27 (main) to 0 (PR) cycles after applying the below diff. Hooray!

diff --git a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
index 2ccc0e5480..7c2c9852ad 100644
--- a/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
+++ b/frontend/packages/console-plugin-sdk/src/codegen/active-plugins.ts
@@ -58,7 +58,6 @@ export const getActivePluginsModule = (
      activePlugins.push({
        name: '${pkg.name}',
        extensions: [
-          ...require('${pkg.name}/${pkg.consolePlugin.entry}').default,
          ...${extensionHook(pkg)},
        ],
      });
@@ -88,8 +87,6 @@ export const loadActivePluginsForTestPurposes = (
    activePlugins.push({
      name: pkg.name,
      extensions: [
-        // eslint-disable-next-line @typescript-eslint/no-var-requires
-        ...require(`${pkg.name}/${pkg.consolePlugin.entry}`).default,
        ...extensionHook(pkg),
      ],
    });
diff --git a/frontend/webpack.config.ts b/frontend/webpack.config.ts
index 06c8f46b78..ef735a5876 100644
--- a/frontend/webpack.config.ts
+++ b/frontend/webpack.config.ts
@@ -340,10 +340,6 @@ const config: Configuration = {
if (CHECK_CYCLES === 'true') {
  new CircularDependencyPreset({
    exclude: /node_modules|public\/dist|\.(gql|html)$/,
-    // TODO: investigate how to load the plugins registry asynchronously
-    filterModules: /^get-active-plugins\.js$/,
-    // TODO: Fix cycles unveiled by CONSOLE-4837, then remove the below line
-    thresholds: { totalCycles: 5 },
    reportFile: '.webpack-cycles',
  }).apply(config.plugins);
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-11-13T16:30:40Z

yarn dev works fine:

frontend/packages/console-app/src/plugin.tsx

frontend/public/components/RBAC/role-type.ts

vojtechszocs · 2025-11-13T16:48:18Z

/lgtm

Cycle count goes from 27 to 14

Cycle count goes from 14 to 11

Cycle count goes from 11 to 8

Cycle count goes from 8 to 5

Cycle count goes from 5 to 2

Cycle count goes from 2 to 0. Hooray!

These cycles will be addressed by CONSOLE-4806 and CONSOLE-4840

vojtechszocs · 2025-11-13T18:16:15Z

/lgtm

openshift-ci · 2025-11-13T18:16:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-11-13T19:04:11Z

frontend/webpack.config.ts

-    filterModules: /^get-active-plugins\.js$/,
-    // TODO: Fix cycles unveiled by CONSOLE-4837, then remove the below line
-    thresholds: { totalCycles: 10 },
+    thresholds: { totalCycles: 21 }, // TODO(CONSOLE-4806): Set threshold to 0


21 cycles are related to imports in knative-plugin/plugin.tsx / static GuidedTour and will be addressed in #15641 and #15679

yapei · 2025-11-14T06:31:17Z

Run yarn check-cycles locally after applying patch in description

$ ts-node -O '{"module":"commonjs"}' ./node_modules/.bin/webpack --mode=development
(node:48756) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Console active plugins virtual module code generated with 0 errors and 0 warnings
945 assets
20586 modules
webpack 5.97.1 compiled successfully in 82002 ms
✨  Done in 139.14s.

also CI test passed

/verified by @yapei , CI

openshift-ci-robot · 2025-11-14T06:31:29Z

@yapei: This PR has been marked as verified by @yapei,CI.

Details

In response to this:

Run yarn check-cycles locally after applying patch in description

$ ts-node -O '{"module":"commonjs"}' ./node_modules/.bin/webpack --mode=development
(node:48756) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Console active plugins virtual module code generated with 0 errors and 0 warnings
945 assets
20586 modules
webpack 5.97.1 compiled successfully in 82002 ms
✨  Done in 139.14s.

also CI test passed

/verified by @yapei , CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-14T07:25:07Z

/retest-required

Remaining retests: 0 against base HEAD f4d51e9 and 2 for PR HEAD 33ddf26 in total

openshift-ci · 2025-11-14T11:08:46Z

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`33ddf26`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025

openshift-ci bot requested review from cajieh and rawagner November 13, 2025 15:57

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 13, 2025

openshift-ci bot assigned rhamilto and yapei Nov 13, 2025

logonoff force-pushed the CONSOLE-4858-s2e20-drug-testing branch from 5671e5a to 0fcc3d8 Compare November 13, 2025 16:19

vojtechszocs reviewed Nov 13, 2025

View reviewed changes

frontend/packages/console-app/src/plugin.tsx Show resolved Hide resolved

frontend/public/components/RBAC/role-type.ts Outdated Show resolved Hide resolved

logonoff force-pushed the CONSOLE-4858-s2e20-drug-testing branch from 0fcc3d8 to 23d4f5f Compare November 13, 2025 16:47

openshift-ci bot assigned vojtechszocs Nov 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025

logonoff force-pushed the CONSOLE-4858-s2e20-drug-testing branch from 23d4f5f to 832e40e Compare November 13, 2025 18:11

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025

logonoff added 4 commits November 13, 2025 13:11

CONSOLE-4858: Break role cycle

64c50c7

Cycle count goes from 27 to 14

CONSOLE-4858: Break pods cycle

9df96fe

Cycle count goes from 14 to 11

CONSOLE-4858: Break TextFilter cycle

694673d

Cycle count goes from 11 to 8

CONSOLE-4858: Break redux action cycle

e090975

Cycle count goes from 8 to 5

logonoff added 3 commits November 13, 2025 13:11

CONSOLE-4858: Break k8sBasePath cycle

837dc98

Cycle count goes from 5 to 2

CONSOLE-4858: Break dashboards cycle

baa9292

Cycle count goes from 2 to 0. Hooray!

CONSOLE-4858: Remove get-active-plugins filter

33ddf26

These cycles will be addressed by CONSOLE-4806 and CONSOLE-4840

logonoff force-pushed the CONSOLE-4858-s2e20-drug-testing branch from 832e40e to 33ddf26 Compare November 13, 2025 18:11

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Nov 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025

logonoff mentioned this pull request Nov 13, 2025

CONSOLE-4840: Migrate GuidedTour to dynamic #15679

Merged

logonoff commented Nov 13, 2025

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 14, 2025

openshift-merge-bot bot merged commit d673d10 into openshift:main Nov 14, 2025
7 of 8 checks passed

logonoff deleted the CONSOLE-4858-s2e20-drug-testing branch November 14, 2025 12:23

CONSOLE-4858: Fix 27 cycles #15723

CONSOLE-4858: Fix 27 cycles #15723

Uh oh!

Conversation

logonoff commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

vojtechszocs commented Nov 13, 2025

Uh oh!

vojtechszocs commented Nov 13, 2025

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

logonoff Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yapei commented Nov 14, 2025

Uh oh!

openshift-ci-robot commented Nov 14, 2025

Uh oh!

openshift-ci-robot commented Nov 14, 2025

Uh oh!

openshift-ci bot commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

logonoff commented Nov 13, 2025 •

edited

Loading

openshift-ci-robot commented Nov 13, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 13, 2025 •

edited by openshift-ci bot

Loading

logonoff Nov 13, 2025 •

edited

Loading