add integration tests for route creation #1695

yapei · 2019-06-12T07:10:08Z

This PR adds an test case to verify unsecure route is correctly created and hostname is correctly shown on console

@rhamilto Can you please help review? Thanks very much

openshift-ci-robot · 2019-06-12T07:10:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yapei
To complete the pull request process, please assign kyoto
You can assign the PR to them by writing /assign @kyoto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

frontend/integration-tests/data/caddy-docker.json

frontend/integration-tests/tests/networking.scenario.ts

spadgett · 2019-06-12T14:14:10Z

frontend/integration-tests/tests/networking.scenario.ts

+    await networkingView.createUnsecureRoute(unsecureRouteName, unsecureServiceName);
+    await networkingView.visitRoutesDetailsPage(appHost, testName, unsecureRouteName);
+    await crudView.isLoaded();
+    const hostSearchLabel = 'LOCATION';


This will likely break after #1465. But it would be much better to add a data-test- attribute to find the value.

spadgett · 2019-06-12T14:14:41Z

frontend/integration-tests/tests/networking.scenario.ts

+      expect(items[hostnameFoundIndex].getText()).toBe(`http://${ hostNameInYAML }`);
+    });
+    expect($$('.co-m-pane__body').get(1).getText()).toContain('TLS Settings');
+    expect($$('.co-m-pane__body').get(1).getText()).toContain('TLS is not enabled');


This is fragile. Please add a data-test- attribute.

Sorry I was still testing against 4.1 cluster, bridged to OKD 4.2 cluster.

Sam, I didn't see data-test attribute is added for TLS Settings section

<div class="co-m-pane__body"> <h2 class="co-section-heading"> TLS Settings </h2> TLS is not enabled. </div>

On Routes page, only right column in Route Overview has a data-test attribute

spadgett · 2019-06-12T14:15:47Z

frontend/integration-tests/views/networking.view.ts

+const createRouteForm = $('.co-create-route');
+const saveButton = $('#save-changes');
+
+const chooseFromList = async(itemName: string) => {


We might want to pull this into a file like form.view.ts so it can be reused elsewhere for any dropdown.

Do we need a different file name for common views? I'm wondering if getResourceJSON, isValueInJSONPath in secrets.view.ts can be moved out as well

spadgett · 2019-06-12T14:16:35Z

frontend/integration-tests/tests/networking.scenario.ts

+    await networkingView.visitRoutesDetailsPage(appHost, testName, unsecureRouteName);
+    await crudView.isLoaded();
+    const hostSearchLabel = 'LOCATION';
+    const hostnameFoundIndex = await networkingView.getKeyIndex(await $$('dt'), hostSearchLabel, async(label) => {


This is fragile. Please use a data-test- attribute

spadgett · 2019-06-12T14:19:27Z

frontend/integration-tests/views/secrets.view.ts

  return result === value;
 };
+
+export const getPathInJSON = (path: string, name: string, namespace: string, kind: string) => {


I'd change this to simply return the object instead of taking in a path. Then the caller can use the object in any way.

Sounds much better, I will update

spadgett · 2019-06-12T14:20:19Z

Error: Command failed: kubectl create -f ./integration-tests/data/caddy-docker.json -n test-sqbuo
W0612 09:55:21.099288    2494 factory_object_mapping.go:423] Failed to download OpenAPI (the server could not find the requested resource), falling back to swagger
error: error validating "./integration-tests/data/caddy-docker.json": error validating data: the server could not find the requested resource; if you choose to ignore these errors, turn validation off with --validate=false

yapei · 2019-06-17T06:02:43Z

/test e2e-aws-console

yapei · 2019-06-17T06:25:09Z

Error: Command failed: kubectl create -f ./integration-tests/data/caddy-docker.json -n test-sqbuo
W0612 09:55:21.099288    2494 factory_object_mapping.go:423] Failed to download OpenAPI (the server could not find the requested resource), falling back to swagger
error: error validating "./integration-tests/data/caddy-docker.json": error validating data: the server could not find the requested resource; if you choose to ignore these errors, turn validation off with --validate=false

Hi Sam, is this a compatibility issue? when I run locally it passed, I feel like it's an issue of incompatible version between kubectl and server in our test container

kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.2", GitCommit:"bdaeafa71f6c7c04636251031f93464384d54963", GitTreeState:"clean", BuildDate:"2017-10-24T19:48:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.0+42b6806", GitCommit:"42b6806", GitTreeState:"clean", BuildDate:"2019-06-14T22:12:12Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

yapei · 2019-06-20T05:50:01Z

/test e2e-aws-console

yapei · 2019-06-20T10:14:46Z

I will test the PR against latest code, e2e-aws-console passes locally(old code) and fails in CI(new code)

yapei · 2019-06-28T09:53:40Z

/test e2e-aws

yapei · 2019-06-28T09:54:43Z

@spadgett I've updated the code again, can you please help review? Thanks

yapei · 2019-07-01T01:31:10Z

Will close and open a new one

openshift-ci-robot requested review from TheRealJon and jcaianirh June 12, 2019 07:10

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2019

add integration tests for route creation

7c82b03

yapei force-pushed the master branch from bb82b19 to 7c82b03 Compare June 12, 2019 08:51

spadgett requested changes Jun 12, 2019

View reviewed changes

spadgett added this to the v4.2 milestone Jun 14, 2019

yapei force-pushed the master branch from df8b4a2 to 5553993 Compare June 17, 2019 04:43

yapei force-pushed the master branch from 5553993 to 37a14fd Compare June 20, 2019 02:32

some updates

cb9c6bc

yapei force-pushed the master branch from 37a14fd to cb9c6bc Compare June 20, 2019 02:34

Merge branch 'master' of github.com:openshift/console

0e28d70

yapei added 3 commits June 21, 2019 10:10

Merge branch 'master' of github.com:openshift/console

4dfc624

Merge branch 'master' of github.com:openshift/console

7c42bb0

updates

6e03cd9

yapei force-pushed the master branch from 814b694 to 6e03cd9 Compare June 28, 2019 07:03

yapei closed this Jul 1, 2019

yapei mentioned this pull request Jul 1, 2019

add integration tests for route creation #1866

Closed

add integration tests for route creation #1695

add integration tests for route creation #1695

Uh oh!

Conversation

yapei commented Jun 12, 2019

Uh oh!

openshift-ci-robot commented Jun 12, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spadgett Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

yapei Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yapei Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

yapei Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

spadgett Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

yapei Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

spadgett commented Jun 12, 2019

Uh oh!

yapei commented Jun 17, 2019

Uh oh!

yapei commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yapei commented Jun 20, 2019

Uh oh!

yapei commented Jun 20, 2019

Uh oh!

yapei commented Jun 28, 2019

Uh oh!

yapei commented Jun 28, 2019

Uh oh!

yapei commented Jul 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yapei Jun 13, 2019 •

edited

Loading

yapei Jun 13, 2019 •

edited

Loading

yapei commented Jun 17, 2019 •

edited

Loading