Skip to content

Conversation

@yapei
Copy link
Contributor

@yapei yapei commented Jul 1, 2019

@spadgett #1695 is substituted by this one, I should have addressed all comments. Could you please help review again? Thanks very much

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2019
@yapei
Copy link
Contributor Author

yapei commented Jul 1, 2019

/test e2e-aws

@spadgett spadgett added this to the v4.2 milestone Jul 1, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the one integration test this adds is already covered by a spec test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any li on the page? This doesn't seem like a good helper and will break if any other li is introduced. It would be better to write one specifically for dropdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated using existing code, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only move some common code to utils.view.ts, no other scenarios added

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2019
@yapei
Copy link
Contributor Author

yapei commented Jul 3, 2019

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yapei
To complete the pull request process, please assign kyoto
You can assign the PR to them by writing /assign @kyoto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2019
@yapei yapei closed this Aug 6, 2019
@openshift-ci-robot
Copy link
Contributor

@yapei: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 431ea55 link /test images
ci/prow/frontend 431ea55 link /test frontend
ci/prow/backend 431ea55 link /test backend
ci/prow/e2e-aws-console-olm 431ea55 link /test e2e-aws-console-olm
ci/prow/e2e-aws-console 431ea55 link /test e2e-aws-console
ci/prow/e2e-aws 431ea55 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants