Skip to content

Conversation

@TheRealJon
Copy link
Member

AbortController/AbortSignal is not supported in some older browser versions. Added a polyfill which prevents a runtime error where AbortController is undefined in those browsers. When AbortController is unsupported, the polyfill will cause in-flight fetch promises to reject when the abort signal is triggered.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720045

@TheRealJon TheRealJon requested a review from spadgett June 20, 2019 14:35
@spadgett spadgett changed the title Add polyfill for AbortController Bug 1720045: Add polyfill for AbortController Jun 20, 2019
@spadgett spadgett added this to the v4.2 milestone Jun 20, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 20, 2019
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references a valid Bugzilla bug.

Details

In response to this:

Bug 1720045: Add polyfill for AbortController

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bc8bedd into openshift:master Jun 21, 2019
@TheRealJon TheRealJon deleted the bug-1720045 branch June 26, 2019 15:25
@spadgett spadgett mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants