Skip to content

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Jun 24, 2019

Switch to https://github.com/mysticatea/abort-controller polyfill which is intended for use with whatwg-fetch (which is what we are using).

Polyfill added by #1775 caused a regression because it was intended for use with node-fetch.

Tested against latest Chrome and Firefox to ensure native AbortController support isn't broken by polyfill. No runtime errors.

Tested against Firefox v56.0.2 to ensure polyfill works as expected. No runtime errors.

@TheRealJon TheRealJon requested review from kyoto and spadgett June 24, 2019 15:49
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2019
@spadgett
Copy link
Member

/cc @kyoto

@spadgett spadgett changed the title Switch to WHATWG abort controller polyfill Bug 1720045: Switch to WHATWG abort controller polyfill Jun 24, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 24, 2019
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references a valid Bugzilla bug.

Details

In response to this:

Bug 1720045: Switch to WHATWG abort controller polyfill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@TheRealJon
Copy link
Member Author

Looks like an actual test flake:

Failed Specs:

1) Modal Annotations : Delete Annotation
   StaleElementReferenceError: stale element reference: element is not attached to the page document
     (Session info: headless chrome=73.0.3683.86)
     (Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)
       at Object.checkLegacyResponse /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/error.js:546:15
       at parseHttpResponse /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:509:13
       at doSend.then.response /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:441:30
       at process._tickCallback internal/process/next_tick.js:68:7
   From: Task: WebElement.getAttributevalue
       at Driver.schedule /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/webdriver.js:807:17
       at WebElement.schedule_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/webdriver.js:2010:25
       at WebElement.getAttribute /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/webdriver.js:2263:17
       at actionFn /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:89:44
       at Array.map <anonymous>
       at actionResults.getWebElements.then /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:461:65
       at ManagedPromise.invokeCallback_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14
       at TaskQueue.execute_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3084:14
       at TaskQueue.executeNext_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3067:27
       at asyncRun /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2927:27Error
       at ElementArrayFinder.applyAction_ /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:459:27
       at ElementArrayFinder.anonymous function.args [as getAttribute] /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:91:29
       at ElementFinder.anonymous function.args [as getAttribute] /go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:831:22
       at /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:59:69
       at step /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:32:23
       at Object.next /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:13:53
       at fulfilled /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:4:58
       at process._tickCallback internal/process/next_tick.js:68:7

@spadgett
Copy link
Member

Yeah, known flake: https://jira.coreos.com/browse/CONSOLE-1294

We should track that down

@spadgett spadgett added this to the v4.2 milestone Jun 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit cc08f18 into openshift:master Jun 24, 2019
@TheRealJon TheRealJon deleted the abortcontroller-polyfill branch June 26, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants