[WIP] Add ConsoleLogLink CRD to enable custom log links

[rhamilto]

Fixes #1678
Resolves https://jira.coreos.com/browse/CONSOLE-1528

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: consoleloglinks.console.openshift.io
  annotations:
    displayName: ConsoleLogLinks
    description: Extension for customizing OpenShift web console pod log links
spec:
  scope: Cluster
  group: console.openshift.io
  versions:
  - name: v1
    served: true
    storage: true
  names:
    plural: consoleloglinks
    singular: consoleloglink
    kind: ConsoleLogLink
    listKind: ConsoleLogLinkList
  additionalPrinterColumns:
  - name: Text
    type: string
    JSONPath: .spec.text
  - name: HrefTemplate
    type: string
    JSONPath: .spec.hrefTemplate
  - name: Age
    type: date
    JSONPath: .metadata.creationTimestamp
  subresources:
    status: {}
  validation:
    openAPIV3Schema:
      properties:
        spec:
          type: object
          description: Represents console pod log link customizations spec
          required:
          - text
          - hrefTemplate
          properties:
            text:
              type: string
              description: Text of the link
            hrefTemplate:
              type: string
              description: Absolute secure URL including name or id, container, and namespace variables for the pod log link (must use https).  e.g., https://example.com/logs?name=\${name}&container=\${container}&namespace=\${namespace}
              pattern: '^https://'
            namespaceFilter:
              type: string
              description: Regular expression used to restrict a log link to a matching namespace

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/cc @jcantrill

[benjaminapetersen]

Are we settled on the name consolepodloglinks?
If so, I should update the list in this PR: openshift/origin#23231
(probably will just be a follow-on since we already have the PR approved to merge)

[spadgett]

Better to use the link resource UID for the key if we can

[spadgett]

If we can't find a way to prevent code execution with _.template, we could fall back to...

template
  .replace('${name}', encodeURIComponent(resource.metadata.name))
  .replace('${container}', encodeURIComponent(containerName))
  // ...

[spadgett]

Use k8sGet or Firehose

[rhamilto]

Adding @spadgett's comment back after code changes:

If we can't find a way to prevent code execution with _.template, we could fall back to...

template
  .replace('${name}', encodeURIComponent(resource.metadata.name))
  .replace('${container}', encodeURIComponent(containerName))
  // ...

[openshift-ci-robot]

@rhamilto: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/frontend	a9d674e	link	/test frontend

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.