Skip to content

Add ConsoleExternalLogLink CRD to enable custom log links #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 20, 2019
Merged

Add ConsoleExternalLogLink CRD to enable custom log links #1892

openshift-merge-robot merged 1 commit into from
Jul 20, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 2, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2019
rhamilto
rhamilto commented Jul 2, 2019
View reviewed changes
@rhamilto rhamilto changed the title Add ConsoleLogLink CRD to enable custom log links [WIP] Add ConsoleLogLink CRD to enable custom log links Jul 2, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@rhamilto rhamilto force-pushed the console-1528 branch 2 times, most recently from 5a36570 to a800008 Compare July 5, 2019 16:54
@rhamilto
Copy link
Member Author

rhamilto commented Jul 5, 2019

Updated. @spadgett, PTAL.

@rhamilto rhamilto changed the title [WIP] Add ConsoleLogLink CRD to enable custom log links Add ConsoleLogLink CRD to enable custom log links Jul 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
spadgett
spadgett reviewed Jul 5, 2019
View reviewed changes
@rhamilto rhamilto force-pushed the console-1528 branch 2 times, most recently from ac9c6d4 to ba89494 Compare July 5, 2019 18:55
@rhamilto
Copy link
Member Author

rhamilto commented Jul 8, 2019

/retest

benjaminapetersen
benjaminapetersen reviewed Jul 16, 2019
View reviewed changes
benjaminapetersen
benjaminapetersen reviewed Jul 17, 2019
View reviewed changes
frontend/public/components/utils/resource-log.jsx Outdated
Copy link
Contributor

@benjaminapetersen benjaminapetersen Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be in a try...catch or an _.attempt()?
What if a provider gives you something invalid.

Copy link
Contributor

@benjaminapetersen benjaminapetersen Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing this:
https://github.com/openshift/api/pull/380/files#diff-9754f97c9c90951cc7df5ac76b6eea86R36
We probably need to be very clear about the expected format of the regex in our example, as well as ensure we give a couple good examples. This kind of thing can be annoying if you don't know if ^openshift- is ok, or if /^openshift-/g is needed.

Copy link
Contributor

@benjaminapetersen benjaminapetersen Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhadvig fyi

Copy link
Member

@spadgett spadgett Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (namespaceFilter && namespace.search(namespaceFilter) === -1) {
if (namespaceFilter && namespace.search(new RegExp(namespaceFilter, 'g')) === -1) {

benjaminapetersen
benjaminapetersen reviewed Jul 17, 2019
View reviewed changes
benjaminapetersen
benjaminapetersen reviewed Jul 17, 2019
View reviewed changes
@rhamilto rhamilto changed the title Add ConsoleLogLink CRD to enable custom log links Add ConsoleExternalLogLink CRD to enable custom log links Jul 17, 2019
spadgett
spadgett reviewed Jul 18, 2019
View reviewed changes
@rhamilto
Copy link
Member Author

rhamilto commented Jul 18, 2019

@spadgett, suggestions accepted.

@rhamilto
Copy link
Member Author

rhamilto commented Jul 18, 2019

/retest

spadgett
spadgett reviewed Jul 18, 2019
View reviewed changes
spadgett
spadgett approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.2 milestone Jul 18, 2019
@spadgett
Copy link
Member

spadgett commented Jul 18, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@rhamilto
Copy link
Member Author

rhamilto commented Jul 19, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Jul 20, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9a8898c into openshift:master Jul 20, 2019
@spadgett spadgett mentioned this pull request Jul 21, 2019
Closed
@rhamilto rhamilto deleted the console-1528 branch July 22, 2019 12:53
@outcoldman outcoldman mentioned this pull request Oct 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

+1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

Pod Log Links Extension

6 participants

@rhamilto @openshift-ci-robot @spadgett @openshift-bot @benjaminapetersen @openshift-merge-robot