Migrate Gauge component from Plotly to PatternFly 4 #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
TheRealJon
changed the title
spadgett
reviewed
Jun 20, 2019
Member
|
/assign @kyoto |
spadgett
reviewed
Jun 21, 2019
Member
Author
|
@spadgett I've addressed your feedback |
kyoto
reviewed
Jun 25, 2019
kyoto
reviewed
Jun 25, 2019
Member
|
Thanks @TheRealJon, looks great! I added two very minor comments, but LGTM. |
spadgett
reviewed
Jun 25, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace plotly.js gauge implementation with PF4 ChartDonutThreshold and ChartDonutUtilization.
Cluster Overview
Resource Quota Details
