Skip to content

Add Unit tests for QuotaGaugeCharts and QuotaScopesList #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiaocwan wants to merge 2 commits into from
Closed

Add Unit tests for QuotaGaugeCharts and QuotaScopesList #1784

xiaocwan wants to merge 2 commits into from

Conversation

@xiaocwan
Copy link
Contributor

@xiaocwan xiaocwan commented Jun 21, 2019 •
edited
Loading

Add a unit test for checking QuotaGaugeCharts and QuotaScopesList .
@spadgett Could you help to review plz? Thanks!

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2019
@xiaocwan xiaocwan force-pushed the quota-unit branch 2 times, most recently from df4d26a to 8395a78 Compare June 21, 2019 08:02
@spadgett
Copy link
Member

spadgett commented Jun 21, 2019

These charts are changing in #1783. We should write the tests for the new charts.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@spadgett spadgett added this to the v4.2 milestone Jun 21, 2019
@xiaocwan
Copy link
Contributor Author

xiaocwan commented Jun 27, 2019

#1783 is merged.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2019
@xiaocwan
Copy link
Contributor Author

xiaocwan commented Jun 27, 2019

Hi @spadgett
It's been rebased on latest code now, could you please have a review? Thanks!

@xiaocwan
Copy link
Contributor Author

xiaocwan commented Jul 2, 2019 •
edited
Loading

@jhadvig @jeff-phillips-18 Could you help to review please? Thanks!

spadgett
spadgett approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Apologies for missing this PR.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2019
@spadgett
Copy link
Member

spadgett commented Sep 9, 2019

/lgtm cancel

looks like the tests need to be updated for current master

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeff-phillips-18, xiaocwan
To complete the pull request process, please assign spadgett
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2019
@spadgett spadgett modified the milestones: v4.2, v4.3 Sep 11, 2019
@spadgett spadgett removed this from the v4.3 milestone Dec 3, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 22, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2020

@xiaocwan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/frontend 5aa4ffb link /test frontend
ci/prow/e2e-aws-console 5aa4ffb link /test e2e-aws-console
ci/prow/e2e-aws-console-olm 5aa4ffb link /test e2e-aws-console-olm
ci/prow/e2e-gcp-console 5aa4ffb link /test e2e-gcp-console
ci/prow/e2e-gcp 5aa4ffb link /test e2e-gcp
ci/prow/analyze 5aa4ffb link /test analyze
ci/prow/kubevirt-plugin 5aa4ffb link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 6, 2020

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 6, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 6, 2020

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2020

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiaocwan @spadgett @openshift-ci-robot @openshift-bot @jeff-phillips-18