Allow overriding the active plugin list

[vojtechszocs]

Follow-up to #1871 (un-merged)

This PR adds the ability to override the list of active Console plugins.

Active plugins are used

• for testing: packages/console-app/src/__tests__/plugin-test-utils.ts creates a test registry from all active plugins (for "what's tested" vs. "what's built" consistency)
• for building: webpack.config.ts creates a virtual @console/active-plugins module that returns the list of all active plugins for use in Console (i.e. plugins to be included in the output bundle)
• for reporting: plugin-stats.ts dynamically loads entry modules of all active plugins (executed as part of devel & prod builds)

By default, plugins must be listed in packages/console-app/package.json file under dependencies key in order to be considered active.

With this PR, it's possible to override that via CONSOLE_PLUGINS env. variable:

# use standard active plugin resolution logic
yarn dev

# for core Console development (no additional plugins)
CONSOLE_PLUGINS=@console/app yarn dev

# for customized plugin development experience
CONSOLE_PLUGINS=@console/app,@console/foo,@console/bar yarn dev

The CONSOLE_PLUGINS override is consistently applied to

• dev (webpack)
• build (webpack)
• test (Jest / extension checks)
• plugin-stats (ts-node)

/cc @spadgett @alecmerdler @christianvogt

[vojtechszocs]

cc @rawagner @mareklibra @jelkosz

[vojtechszocs]

Note: this check was added to reflect the expectation that Console (app) itself is a plugin, i.e. packages/console-app/src/plugin.tsx.

[vojtechszocs]

@alecmerdler @spadgett If you'd like, we can use a shorter form e.g.

CONSOLE_PLUGINS=app,foo,bar yarn dev

instead of

CONSOLE_PLUGINS=@console/app,@console/foo,@console/bar yarn dev

since all Console plugin pkg names are expected to use @console scope anyway.

[christianvogt]

@vojtechszocs being explicit is fine. You could add support for both and if there's no scope you assume the @console scope.

[vojtechszocs]

@vojtechszocs being explicit is fine. You could add support for both and if there's no scope you assume the @console scope.

Agreed, will do.

[alecmerdler]

Before:

$ yarn run dev
...
9525 modules
Time: 52448ms

After:

$ yarn run dev
...
8594 modules
Time: 44883ms

Nice!

[alecmerdler]

Thanks for adding this!
/lgtm

[alecmerdler]

I guess this does adhere to the real web API. But the existing way is what it should be (in a FP world).

[vojtechszocs]

Yup, the web storage API could be better 😃 the above change just reflects the method signature in node_modules/typescript/lib/lib.dom.d.ts

setItem(key: string, value: string): void;

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [alecmerdler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment