Skip to content

Conversation

@vojtechszocs
Copy link
Contributor

This PR addresses #1875 (comment)

1) if package scope isn't specified, use @console

Following commands are equivalent:

CONSOLE_PLUGINS=dev-console,metal3-plugin yarn dev
CONSOLE_PLUGINS=@console/dev-console,@console/metal3-plugin yarn dev

2) ensure @console/app is always in the package list

Following commands are equivalent:

CONSOLE_PLUGINS=dev-console yarn dev
CONSOLE_PLUGINS=app,dev-console yarn dev

@alecmerdler For development without any additional plugins, you can use any of the following:

CONSOLE_PLUGINS= yarn dev
CONSOLE_PLUGINS=app yarn dev

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2019
@vojtechszocs
Copy link
Contributor Author

/cc @alecmerdler @christianvogt

Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c2dd9db into openshift:master Jul 4, 2019
@spadgett spadgett added this to the v4.2 milestone Jul 5, 2019
@logonoff logonoff deleted the improve-plugin-list-override branch September 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants