Skip to content

Add 'Virtual Machines' label to the vm list page #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 7, 2019
Merged

Add 'Virtual Machines' label to the vm list page #2702

openshift-merge-robot merged 1 commit into from
Oct 7, 2019

Conversation

@irosenzw
Copy link
Contributor

@irosenzw irosenzw commented Sep 12, 2019

Display 'No Virtual Machines Found' label when there are no
VMs to present instead of showing just 'Not Found' label.

Fixes: https://bugzilla.redhat.com/1743459

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2019

Hi @irosenzw. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin labels Sep 12, 2019
@pcbailey
Copy link
Contributor

pcbailey commented Sep 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2019
@irosenzw
Copy link
Contributor Author

irosenzw commented Sep 15, 2019

/assign @alecmerdler

@irosenzw
Copy link
Contributor Author

irosenzw commented Sep 15, 2019

/test e2e-aws-console

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2019

@irosenzw: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alecmerdler
alecmerdler approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@irosenzw
Copy link
Contributor Author

irosenzw commented Sep 16, 2019

/assign @pcbailey

@irosenzw irosenzw force-pushed the fix-virtual-machine-label branch from cdcb854 to a375faa Compare September 19, 2019 06:47
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/dashboard Related to dashboard component/dev-console Related to dev-console component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2019
@irosenzw irosenzw force-pushed the fix-virtual-machine-label branch from a375faa to 74444b7 Compare September 26, 2019 09:28
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@vojtechszocs
Copy link
Contributor

vojtechszocs commented Sep 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@vojtechszocs
Copy link
Contributor

vojtechszocs commented Sep 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Sep 30, 2019

/hold
for #2865 (sorry)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@spadgett
Copy link
Member

spadgett commented Sep 30, 2019

/hold cancel
will need rebase (sorry)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@irosenzw irosenzw force-pushed the fix-virtual-machine-label branch from 74444b7 to 8205bcc Compare October 2, 2019 06:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@irosenzw
Add 'Virtual Machines' label to the vm list page
877112a 
Display 'No Virtual Machines Found' label when there are no
VMs to present instead of showing just 'Not Found' label.

Fixes: https://bugzilla.redhat.com/1743459

Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@irosenzw irosenzw force-pushed the fix-virtual-machine-label branch from 8205bcc to 877112a Compare October 2, 2019 06:12
@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 7, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2019
@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, irosenzw, pcbailey, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a399079 into openshift:master Oct 7, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

1 more reviewer

@alecmerdler alecmerdler alecmerdler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

@pcbailey pcbailey

@alecmerdler alecmerdler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@irosenzw @openshift-ci-robot @pcbailey @vojtechszocs @spadgett @alecmerdler @openshift-merge-robot