Skip to content

Conversation

@spadgett
Copy link
Member

No time like the present.

/cc @christianvogt

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/core Related to console core functionality component/dashboard Related to dashboard component/monitoring Related to monitoring size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2019
@christianvogt
Copy link
Contributor

christianvogt commented Sep 29, 2019

Are you going to try and remove the eslint rules from the root now too? Or leave that for a followup pr?
edit: got my answer. Addressing eslint rules will be future work.

@spadgett spadgett changed the title [WIP] Enable prettier on frontend/ Enable prettier on frontend/ Sep 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2019
@spadgett
Copy link
Member Author

Are you going to try and remove the eslint rules from the root now too? Or leave that for a followup pr?

For now, I've only removed the rules that duplicate prettier. I thought we'd work on additional changes in follow-up PRs.

@christianvogt
Copy link
Contributor

/lgtm

A moment of silence for all those pending PRs.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@spadgett
Copy link
Member Author

Rebased (I might need to hold other component/core PRs to get this through...)

// "editor.formatOnSave": true
// },
"[javascript]": {
"editor.formatOnSave": true
Copy link
Member Author

@spadgett spadgett Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianvogt fyi, i went ahead and uncommented these lines to always enable prettier in vscode

@spadgett
Copy link
Member Author

I've put a hold on other component/core PRs in the queue until this merges.

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 88dc7f8 into openshift:master Sep 30, 2019
@spadgett spadgett deleted the prettier branch September 30, 2019 18:16
@spadgett spadgett added this to the v4.3 milestone Sep 30, 2019
@spadgett spadgett added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/monitoring Related to monitoring kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants