Skip to content

Make storage class dropdown consistent #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 1, 2019
Merged

Make storage class dropdown consistent #2869

openshift-merge-robot merged 1 commit into from
Oct 1, 2019
+12 −35

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 30, 2019

Fixes https://jira.coreos.com/browse/CONSOLE-1797
Item addressed

  • Prevent resource badge characters from wrapping
  • Make "New claim" dropdown full width to match "Use existing claim" dropdown
  • Correct alignment of title and secondary grey text
  • match secondary grey text size with Search dropdown

Fixed

Screen Shot 2019-09-26 at 3 37 50 PM

Screen Shot 2019-09-26 at 3 38 01 PM

Screen Shot 2019-09-27 at 3 05 40 PM

Screen Shot 2019-09-27 at 3 05 52 PM

@sg00dwin sg00dwin requested a review from rhamilto September 30, 2019 14:22
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2019
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 30, 2019
@sg00dwin sg00dwin force-pushed the add-storage-form-fixes branch from 7636581 to c647c3d Compare September 30, 2019 14:47
rhamilto
rhamilto approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 30, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Sep 30, 2019

/hold
for #2865

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@spadgett
Copy link
Member

spadgett commented Sep 30, 2019

/hold cancel
will need rebase (sorry)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@sg00dwin sg00dwin force-pushed the add-storage-form-fixes branch from c647c3d to 2775bf0 Compare October 1, 2019 14:38
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
rhamilto
rhamilto approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 139cab3 into openshift:master Oct 1, 2019
@sg00dwin sg00dwin deleted the add-storage-form-fixes branch October 2, 2019 15:30
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@sg00dwin @rhamilto @spadgett @openshift-ci-robot @openshift-merge-robot