Skip to content

Follow on to update inline edit links in kubevirt-plugin #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sg00dwin wants to merge 1 commit into from
Closed

Follow on to update inline edit links in kubevirt-plugin #2719

sg00dwin wants to merge 1 commit into from

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 13, 2019

related to #2666

this also no longer used co-modal-btn-link styles

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2019
@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from b1c51a9 to 7d22524 Compare September 13, 2019 22:14
@sg00dwin sg00dwin mentioned this pull request Sep 13, 2019
Merged
@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from 7d22524 to a804d2d Compare September 16, 2019 13:46
@spadgett spadgett added this to the v4.3 milestone Sep 17, 2019
@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 13:39
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/assign @mareklibra @vojtechszocs

@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/hold
as it looks like this depends on #2666 (since we're removing styles)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2019
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/retest

@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from a804d2d to 824b1fa Compare September 17, 2019 20:32
@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/dev-console Related to dev-console component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2019
@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from 824b1fa to 76a2585 Compare September 18, 2019 14:59
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
To complete the pull request process, please assign vojtechszocs
You can assign the PR to them by writing /assign @vojtechszocs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 18, 2019

/retest

@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from 76a2585 to d757ddc Compare September 19, 2019 16:56
@sg00dwin sg00dwin force-pushed the kubevirt-plugin-modal-btn-link-updates branch from d757ddc to 8281705 Compare September 19, 2019 21:52
@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 19, 2019

@rhamilto ptal

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2019

@sg00dwin: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8281705 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 23, 2019

Since #2392 changes the button location and uses a new EditButton component, I'm going to close this pr. And open a request to update EditButton to switch to the PF4 Button component so it's consistent with related updates being made other parts of the console.

@sg00dwin sg00dwin closed this Sep 23, 2019
@sg00dwin sg00dwin deleted the kubevirt-plugin-modal-btn-link-updates branch December 9, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@vojtechszocs vojtechszocs

@mareklibra mareklibra

Labels

component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@sg00dwin @spadgett @openshift-ci-robot @vojtechszocs @mareklibra