Skip to content

kubevirt: add Networking Tab to CreateVMWizard #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 10, 2019
Merged

kubevirt: add Networking Tab to CreateVMWizard #2757

openshift-merge-robot merged 2 commits into from
Oct 10, 2019

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Sep 18, 2019 •
edited
Loading

  • add/update/remove network interfaces according to new design
  • add PXE network selector
  • remove background color from ResultsRow

depends on:

@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2019
@atiratree
Copy link
Member Author

atiratree commented Sep 18, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch 7 times, most recently from e08c79f to 24f1887 Compare September 23, 2019 10:30
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from 24f1887 to eb2f5cc Compare September 23, 2019 11:34
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from eb2f5cc to 5a5e120 Compare September 24, 2019 13:45
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@atiratree atiratree changed the base branch from master-4.3 to master September 26, 2019 09:32
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch 3 times, most recently from 1dac776 to 67a58c8 Compare September 27, 2019 13:27
@atiratree atiratree mentioned this pull request Sep 27, 2019
Merged
1 task
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch 2 times, most recently from d777e4e to 4e891cb Compare September 30, 2019 14:40
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from 4e891cb to d617599 Compare October 7, 2019 12:39
@atiratree
Copy link
Member Author

atiratree commented Oct 7, 2019

screenshots

nics

nics2

@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from cd8c75c to 9866c8d Compare October 8, 2019 10:38
@atiratree
Copy link
Member Author

atiratree commented Oct 8, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from ec948ce to 9866c8d Compare October 8, 2019 11:09
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from 9866c8d to e070673 Compare October 8, 2019 15:44
@atiratree
Copy link
Member Author

atiratree commented Oct 8, 2019

/retest

1 similar comment
@atiratree
Copy link
Member Author

atiratree commented Oct 8, 2019

/retest

@suomiy
kubevirt: add Networking Tab to CreateVMWizard
e021ffc 
- add/update/remove of network interfaces according to new design
- add PXE network selector
@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from e070673 to e2f8fc7 Compare October 9, 2019 14:59
@atiratree
Copy link
Member Author

atiratree commented Oct 9, 2019

/retest

@atiratree atiratree force-pushed the kubevirt.createVMWizard.nics branch from e2f8fc7 to 64b1ccd Compare October 9, 2019 16:08
@openshift-merge-robot openshift-merge-robot merged commit 64b1ccd into openshift:master Oct 10, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@atiratree @openshift-ci-robot @spadgett @openshift-merge-robot @suomiy