kubevirt: refactor createDiskRow to DiskModal #2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
component/core
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
4 times, most recently
from
bb0bb46 to
7b2aa1e
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
from
7b2aa1e to
7d602ca
Compare
1 task
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
3 times, most recently
from
65cacd2 to
0270277
Compare
Member
Author
|
screenshot
|
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
4 times, most recently
from
7d7de1a to
ce6961d
Compare
- add/update/remove of network interfaces according to new design - add PXE network selector
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
from
ce6961d to
c8f641e
Compare
- add edit nic functionality - add sources (Container, URL, Attach PVC, Attach Cloned PVC))
atiratree
force-pushed
the
kubevirt.createVMWizard.diskWizard
branch
from
c8f641e to
0d69dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: