Skip to content

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Oct 3, 2019

  • remove unnecesary resource loading for the whole wizard
  • fix bootOrder changes
  • create ReviewList component
  • create CombinedDisk and ProvisionSource wrappers

depends on:

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin labels Oct 3, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch from adfd4fa to a16492d Compare October 3, 2019 09:20
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch 3 times, most recently from b37257f to d848305 Compare October 7, 2019 12:05
@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch 2 times, most recently from 95cc6cd to e3ccd8c Compare October 7, 2019 13:06
@atiratree
Copy link
Member Author

screenshots

disks

disks2

@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch 3 times, most recently from eaa12aa to d782ca3 Compare October 8, 2019 16:41
- add/update/remove of network interfaces according to new design
- add PXE network selector
@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch from d782ca3 to 8a788c9 Compare October 9, 2019 15:10
suomiy added 4 commits October 9, 2019 18:08
- add edit nic functionality
- add sources (Container, URL, Attach PVC, Attach Cloned PVC))
- remove unnecesary resource loading for the whole wizard
- fix bootOrder changes
- create ReviewList component
- create CombinedDisk and ProvisionSource wrappers
@atiratree atiratree force-pushed the kubevirt.createVMWizard.disks branch from 8a788c9 to 7275a26 Compare October 9, 2019 16:09
@openshift-merge-robot openshift-merge-robot merged commit 7275a26 into openshift:master Oct 10, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants