kubevirt: add Advanced Cloud-init Tab to CreateVMWizard #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XXL
Member
Author
|
/retest |
Member
Author
|
screenshots
|
atiratree
force-pushed
the
kubevirt.createVMWizard.cloudInit
branch
6 times, most recently
from
8e6c951 to
6f50819
Compare
- add/update/remove of network interfaces according to new design - add PXE network selector
atiratree
force-pushed
the
kubevirt.createVMWizard.cloudInit
branch
from
6f50819 to
4a579d9
Compare
- add edit nic functionality - add sources (Container, URL, Attach PVC, Attach Cloned PVC))
- remove unnecesary resource loading for the whole wizard - fix bootOrder changes - create ReviewList component - create CombinedDisk and ProvisionSource wrappers
- cloud init data is persisted inside the volume - fix disks editing - create InlineBooleanRadio component
atiratree
force-pushed
the
kubevirt.createVMWizard.cloudInit
branch
from
4a579d9 to
c1908fd
Compare
Member
Author
|
/retest |
Contributor
|
/lgtm Considering size of this PR, it was reviewed f2f off-line. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: