Skip to content

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 20, 2019

So far with just a single Details card.
Additional cards will be added in follow-ups.

Depends on:


podDashboard

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 20, 2019
@mareklibra mareklibra changed the title WIP Add Pod Dashboard Add Pod Dashboard Sep 23, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:36
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2019
@mareklibra
Copy link
Contributor Author

Rebased as dependencies are merged now.
@vojtechszocs , can you please have a look?

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2a9667b into openshift:master Oct 3, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
@spadgett
Copy link
Member

spadgett commented Oct 7, 2019

As a rule, we try to keep master as close to production as possible and only enable features in the UI when they're ready (i.e., if we had to ship tomorrow, does it make sense to ship this as-is?). In this case, I would add the code, but hide the tab until there is more content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants