Skip to content

pods: Dashboard is the default pod-detail tab #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mareklibra wants to merge 2 commits into from
Closed

pods: Dashboard is the default pod-detail tab #2811

mareklibra wants to merge 2 commits into from

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 23, 2019 •
edited
Loading

Depends on:

Just the last commit is relevant.

I would postpone merging of this PR till more cards land on the Pod Detail Dashboard page.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 23, 2019

Cc @andybraren

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 23, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:35
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mareklibra
To complete the pull request process, please assign christianvogt
You can assign the PR to them by writing /assign @christianvogt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 4, 2019

Rebased, ready for review.
But let's hold merging of this till more pod-dashboard cards lands.

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 4, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
vojtechszocs
vojtechszocs suggested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@vojtechszocs vojtechszocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @spadgett this tweaks NavFactory to make href customizable.

frontend/public/components/pod.tsx Outdated
pages={[
{
href: 'dashboard', // TODO: make it default once additional Cards are implemented
href: POD_DETAIL_DASHBOARD_HREF,
Copy link
Contributor

@vojtechszocs vojtechszocs Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to stick with existing convention

href: '',

which makes it clear that this is the default landing page/tab within the details page.

Having a constant for an empty string adds one more level of indirection.

Copy link
Contributor Author

@mareklibra mareklibra Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 7, 2019

@mareklibra LGTM - please un-hold when ready.

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 8, 2019

/retest

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 8, 2019

FYI, there are merge conflicts (needs rebase) and the "hold" label is still there.

@spadgett
Copy link
Member

spadgett commented Oct 8, 2019

We're still discussing the pod dashboard. It largely duplicates the overview tab. Can we hold related PRs for now?

@andybraren
Copy link
Contributor

andybraren commented Oct 8, 2019

Agreed, please keep the hold for now, I'm working on confirming the path forward for this dashboard. (All other dashboards are still good to proceed)

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2019

@mareklibra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 642d70a link /test e2e-gcp-console
ci/prow/e2e-gcp 642d70a link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 22, 2019

The pod-dashboard has been descoped for 4.2.

@mareklibra mareklibra closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@rawagner rawagner Awaiting requested review from rawagner

1 more reviewer

@vojtechszocs vojtechszocs vojtechszocs requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mareklibra @openshift-ci-robot @vojtechszocs @spadgett @andybraren