Skip to content

kubevirt: Refactor IpAddress for reusability #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mareklibra wants to merge 1 commit into from
Closed

kubevirt: Refactor IpAddress for reusability #2810

mareklibra wants to merge 1 commit into from

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 23, 2019 •
edited
Loading

Depends on:

Just the last commit is relevant.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 23, 2019
@mareklibra mareklibra mentioned this pull request Sep 23, 2019
Merged
2 tasks
@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:35
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mareklibra
To complete the pull request process, please assign benjaminapetersen
You can assign the PR to them by writing /assign @benjaminapetersen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 30, 2019

Rebased as #2600 is merged now

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 1, 2019

Not needed anymore

@mareklibra mareklibra closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

No one assigned

Labels

component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mareklibra @openshift-ci-robot