Skip to content

frontend: Update OperatorHub description text #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 25, 2020
Merged

frontend: Update OperatorHub description text #3819

openshift-merge-robot merged 1 commit into from
Jan 25, 2020

Conversation

@rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Dec 20, 2019 •
edited
Loading

Added text from Jira including link to IBM Marketplace. Please note that @alimobrem says the Open Marketplace link isn't currently working; let's hold off on merging until the link works.

Screen Shot 2019-12-20 at 2 16 03 PM

Fixes https://issues.redhat.com/browse/CONSOLE-1971.

Heads up @openshift/team-ux-review.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2019
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Dec 20, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. component/olm Related to OLM labels Dec 20, 2019
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Dec 20, 2019

/approve

Sounds good to hold for now.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 2, 2020

/retest

1 similar comment
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 3, 2020

/retest

@beanh66
Copy link

beanh66 commented Jan 3, 2020

@rebeccaalpert Can you add the external link icon to the right of the "Open Marketplace" link? This helps demonstrate to users that this link opens a new window for the new application vs the Developer Catalog link will navigate within the same application.

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 3, 2020

All set @beanh66:

Screen Shot 2020-01-03 at 3 33 15 PM

@beanh66
Copy link

beanh66 commented Jan 17, 2020

Thanks! @rebeccaalpert Can we make sure it is changed to "Red Hat Marketplace" rather than Open Marketplace?

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 20, 2020

How's this @beanh66?

Screen Shot 2020-01-20 at 10 15 25 AM

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 20, 2020

Updated per Slack changes:
Screen Shot 2020-01-20 at 11 50 29 AM

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2020
spadgett
spadgett reviewed Jan 20, 2020
View reviewed changes
frontend/public/components/utils/webhooks.tsx Outdated
Copy link
Member

@spadgett spadgett Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't right. We should remove from this PR. It's already fixed under #3929

Copy link
Contributor Author

@rebeccaalpert rebeccaalpert Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter added this one. I'll rebase and remove it, but I was getting test failures without it.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2020
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 22, 2020

/hold cancel

Per @itsptk, this is safe to merge at this point.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@itsptk
Copy link

itsptk commented Jan 22, 2020

/hold cancel

Per @itsptk, this is safe to merge at this point.

The decided URL 'https://marketplace.redhat.com/en-us?utm_source=openshift_console' currently does not resolve to the marketplace site, but the marketplace team is aware of the 4.4 timeline via email with @robszumski and it is expected to be active by mid-march.

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 22, 2020

@itsptk Thanks for clarifying.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 22, 2020

/retest

1 similar comment
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Jan 23, 2020

/retest

@robszumski
Copy link
Contributor

robszumski commented Jan 23, 2020

once logged in, I can confirm that this URL is valid

spadgett
spadgett reviewed Jan 24, 2020
View reviewed changes
frontend/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-page.tsx Outdated
Copy link
Member

@spadgett spadgett Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use Link, not an a element

Copy link
Contributor Author

@rebeccaalpert rebeccaalpert Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed change in amended commit.

@rebeccaalpert
frontend: Update OperatorHub description text
3c53354 
Added text from Jira including link to IBM Marketplace.

Fixes https://issues.redhat.com/browse/CONSOLE-1971
spadgett
spadgett approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Jan 24, 2020

/hold
for merge queue fix #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@spadgett
Copy link
Member

spadgett commented Jan 25, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 367ce00 into openshift:master Jan 25, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

9 participants

@rebeccaalpert @benjaminapetersen @beanh66 @itsptk @robszumski @openshift-ci-robot @spadgett @openshift-bot @openshift-merge-robot