Skip to content

fix: catch errors fetching metrics on the pod list page #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 25, 2020
Merged

fix: catch errors fetching metrics on the pod list page #4065

openshift-merge-robot merged 2 commits into from
Jan 25, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 24, 2020

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Jan 24, 2020
benjaminapetersen
benjaminapetersen approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Hate to completely swallow an error, but I don't have a different suggestion atm.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@spadgett spadgett mentioned this pull request Jan 24, 2020
Merged
@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/test analyze

This was referenced Jan 24, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 24, 2020
Merged
Merged
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 24, 2020 

TypeError: Cannot read property 'decodedBodySize' of null
    at /go/src/github.com/openshift/console/frontend/integration-tests/tests/performance.scenario.ts:81:36
    at step (/go/src/github.com/openshift/console/frontend/integration-tests/tests/performance.scenario.ts:33:23)
    at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/tests/performance.scenario.ts:14:53)
    at fulfilled (/go/src/github.com/openshift/console/frontend/integration-tests/tests/performance.scenario.ts:5:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)
From: Task: Run it("downloads new bundle for daemon-set") in control flow
    at UserContext.<anonymous> (/go/src/github.com/openshift/console/frontend/node_modules/jasminewd2/index.js:94:19)
    at attempt (/go/src/github.com/openshift/console/frontend/node_modules/jasmine/node_modules/jasmine-

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/retest

@spadgett spadgett mentioned this pull request Jan 24, 2020
Merged
@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/retest

This was referenced Jan 24, 2020
Merged
Merged
@christianvogt christianvogt mentioned this pull request Jan 25, 2020
Merged
1 task
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/retest

@spadgett spadgett mentioned this pull request Jan 25, 2020
Merged
@benjaminapetersen benjaminapetersen mentioned this pull request Jan 25, 2020
Merged
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
andrewballantyne
andrewballantyne approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9db5868 into openshift:master Jan 25, 2020
@spadgett spadgett deleted the pod-metrics-error branch January 25, 2020 04:20
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 25, 2020

Yay! Look at all the neat Merged references :)

@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

@andrewballantyne andrewballantyne

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @benjaminapetersen @openshift-ci-robot @openshift-bot @andrewballantyne @openshift-merge-robot