Skip to content

Bug 1784937: Improve error handling on global config tab #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 25, 2020
Merged

Bug 1784937: Improve error handling on global config tab #3872

openshift-merge-robot merged 1 commit into from
Jan 25, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 6, 2020

  • Don't show 403 errors for resources you can't list
  • Use ExpandableAlert for showing multiple errors

/cc @benjaminapetersen @rhamilto
@ncameronbritt

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2020

@spadgett: This pull request references Bugzilla bug 1784937, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1784937: Improve error handling on global config tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 8, 2020

/test analyze

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 16, 2020

/lgtm

Apologies, missed this one long enough for there to be a conflict.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 16, 2020
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 16, 2020

/lgtm

@spadgett
Bug 1784937: Improve error handling on global config tab
bbb8e3b 
* Don't show 403 errors for resources you can't list
* Use `ExpandableAlert` for showing multiple errors
@spadgett spadgett force-pushed the global-config-errors branch from b58d96f to bbb8e3b Compare January 24, 2020 14:50
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/test analyze

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

@benjaminapetersen fyi, rebased

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/hold
for merge queue fix #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9ce96ec into openshift:master Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1784937 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1784937: Improve error handling on global config tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the global-config-errors branch January 25, 2020 14:09
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2020

@spadgett: #3872 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/public/components/cluster-settings/global-config.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/cluster-settings/global-config.tsx
CONFLICT (content): Merge conflict in frontend/public/components/cluster-settings/global-config.tsx
Patch failed at 0001 Bug 1784937: Improve error handling on global config tab
Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @openshift-ci-robot @benjaminapetersen @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot