-
Notifications
You must be signed in to change notification settings - Fork 667
Helm release resources page #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm release resources page #4013
Conversation
|
/kind feature |
|
/retest |
1893f21 to
df16e43
Compare
|
^ @openshift/team-devconsole-ux |
df16e43 to
b99efcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debsmita1 can't we use className here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style is a required prop of the TableRow component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types or filters and resources? you can specify the return type as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type for resource and function return type as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this customKind needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reading from a secret resource to display the details of a Helm Release. If I don't send this customKind prop, then it will display the Secret kind in the Resource Icon instead of Helm Release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right here. You can probably use Object.keys(resources).reduce here. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use optional chaining here resourceDetails?.metadata?.labels?.['name']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debsmita1 I'm guessing metadata.labels.name is same as the metadata.name? or is it different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil143 it's different. metadata.name is the name of the secret resource & metadata.labels.name is the helm release name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debsmita1 @serenamarie125 how did we come up with this subset of resources? We cannot find EVERY resource that is in the helm release by using our standard client APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @siamaksade
I'm assuming we want to see all resources in a helm release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christianvogt yes, all resources in a helm release
|
@debsmita1 you are using the label selector Meanwhile the current helm docs state that no such labels are present: https://helm.sh/docs/topics/chart_best_practices/labels/ We need to investigate further another way to identify resources in helm release. |
|
@christianvogt We should be checking a number of labels. There should be utilitiy |
b99efcf to
837d686
Compare
|
@christianvogt @sahil143 the labels are not set automatically in Helm 3 AFAIK. The combination of The Helm Release secret has a |
837d686 to
60d2b45
Compare
|
We cannot use the manifest right now because we'll need backend api for it. It won't work for v3 helm and will also mislead the user on which resources were created. |
|
Right, @akashshinde would get the /helm/manifest API ( equivalent to CC @pedjak |
60d2b45 to
c0e1b28
Compare
1505e92 to
65599af
Compare
ed55252 to
d349636
Compare
sahil143
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified changes locally
/lgtm
|
@christianvogt @debsmita1 @siamaksade @pedjak brought up a very good point in https://issues.redhat.com/browse/APPSVC-382 . You would have to query the actual status of the resources before you show them on the right panel, anyway. |
d349636 to
002255a
Compare
|
/lgtm |
|
Are we using the helm backend API? |
@sbose78 in this PR ? No. I am currently fetching the resources using the label |
|
@serenamarie125 i think we should revisit these filters as well when we fix the resource list. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, debsmita1, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-console |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
|
/hold cancel |
This PR includes:
Refer Jira story: https://issues.redhat.com/browse/ODC-2701

GIF:
