Skip to content

Bug 1783651: Fix "requires approval" install plan link #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 4, 2020
Merged

Bug 1783651: Fix "requires approval" install plan link #3873

openshift-merge-robot merged 1 commit into from
Feb 4, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 6, 2020

No description provided.

@spadgett spadgett added this to the v4.4 milestone Jan 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2020

@spadgett: This pull request references Bugzilla bug 1788246, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1788246: Fix "requires approval" install plan link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 6, 2020

/cc @rhamilto @TheRealJon

@spadgett
Copy link
Member Author

spadgett commented Jan 6, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 6, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2020
@spadgett spadgett changed the title Bug 1788246: Fix "requires approval" install plan link Bug 1783651: Fix "requires approval" install plan link Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@spadgett: This pull request references Bugzilla bug 1783651, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1783651: Fix "requires approval" install plan link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 8, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 14, 2020

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

Adding lgtm label based on @TheRealJon's review

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/hold
for merge queue fix #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/refresh

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Feb 3, 2020

/refresh

@spadgett
Copy link
Member Author

spadgett commented Feb 3, 2020

Closing and reopening to kick CI

@spadgett spadgett closed this Feb 3, 2020
@spadgett spadgett reopened this Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 3, 2020

@spadgett: This pull request references Bugzilla bug 1783651, which is valid.

Details

In response to this:

Bug 1783651: Fix "requires approval" install plan link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 796f910 into openshift:master Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1783651 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1783651: Fix "requires approval" install plan link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 4, 2020

@spadgett: new pull request created: #4170

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 4, 2020
Merged
@spadgett spadgett deleted the install-plan-link branch February 18, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

+1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@spadgett @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @benjaminapetersen @TheRealJon @openshift-merge-robot