Skip to content

Update modal styling to match PF4 modal-box #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 25, 2020
Merged

Update modal styling to match PF4 modal-box #3876

openshift-merge-robot merged 1 commit into from
Jan 25, 2020

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jan 7, 2020

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality labels Jan 7, 2020
@rhamilto
Copy link
Member

rhamilto commented Jan 7, 2020

/retest

1 similar comment
@rhamilto
Copy link
Member

rhamilto commented Jan 7, 2020

/retest

rhamilto
rhamilto reviewed Jan 7, 2020
View reviewed changes
@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 69b0e29 to 38a9195 Compare January 7, 2020 15:10
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Jan 7, 2020
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 7, 2020

/retest

@sg00dwin sg00dwin force-pushed the modal-styling-update branch 2 times, most recently from b6d2e5b to 496dded Compare January 7, 2020 18:47
@sg00dwin sg00dwin force-pushed the modal-styling-update branch 2 times, most recently from c2d7737 to 82eca01 Compare January 10, 2020 18:10
@spadgett
Copy link
Member

spadgett commented Jan 10, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@spadgett
Copy link
Member

spadgett commented Jan 10, 2020

/test e2e-gcp-console

@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 82eca01 to 9b37344 Compare January 13, 2020 15:24
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 13, 2020

/retest

@rhamilto
Copy link
Member

rhamilto commented Jan 13, 2020

/lgtm

@spadgett
Copy link
Member

spadgett commented Jan 14, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 14, 2020

/retest

@sg00dwin sg00dwin added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 9b37344 to 4ab4bd4 Compare January 16, 2020 15:02
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 16, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Jan 19, 2020

/hold
to avoid retest while CI is broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2020
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 20, 2020

/retest

@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 4ab4bd4 to 0aa6b94 Compare January 20, 2020 17:21
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 0aa6b94 to 78fc7dc Compare January 21, 2020 15:32
@spadgett
Copy link
Member

spadgett commented Jan 21, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 21, 2020

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Jan 22, 2020

/retest

@sg00dwin sg00dwin force-pushed the modal-styling-update branch from 78fc7dc to b444601 Compare January 23, 2020 20:14
@sg00dwin sg00dwin force-pushed the modal-styling-update branch from b444601 to 7a445fc Compare January 24, 2020 15:43
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 24, 2020

/retest

@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 24, 2020

retest

@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 24, 2020

/retest

@rhamilto
Copy link
Member

rhamilto commented Jan 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Jan 24, 2020

/hold
for merge queue fix #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@spadgett
Copy link
Member

spadgett commented Jan 25, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4859660 into openshift:master Jan 25, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
@sg00dwin sg00dwin deleted the modal-styling-update branch January 27, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@sg00dwin @rhamilto @spadgett @openshift-bot @openshift-ci-robot @openshift-merge-robot