feat(dev-catalog): Add Capability level filters #3952

abhinandan13jan · 2020-01-14T13:20:44Z

This PR addresses https://issues.redhat.com/browse/ODC-2698

Obtain capability of an operator backed object from CSV annotation and add it as a key capabilityLevel to an item of kind installedOperator
Add capabilty filters to getFilter function
Adjust filterGroup, filterValueMap to accommodate capability filters and reflect as desired in Dev-Catalog.
Set default filter set to true for Auto Pilot, Deep Insights and Full Lifecycle
Added and adjusted tests in catalog.spec.tsx
Convert catalog-item.jsx to tsx
Add typings

~~TO-DO: Add typings for catalog-items.tsx~~

debsmita1 · 2020-01-14T17:05:50Z

frontend/public/components/catalog/catalog-items.jsx

any reason why this has been changed? Also, I don't see this prop being used anywhere in tile-view-page

I've moved this out....

andrewballantyne · 2020-01-15T01:28:12Z

/kind feature

debsmita1 · 2020-01-16T13:16:33Z

@abhinandan13jan You would need to remove the log statements from your PR.

debsmita1 · 2020-01-16T20:41:23Z

frontend/public/components/catalog/catalog-items.tsx

no type ? in the jsx file it was declared as an array

I had left a TODO: remark that I am left to update the typings. I've updated the typings in all places possible. Please re-review :)

Sorry, I didn't notice your TODO remark below the GIF yesterday :/

debsmita1 · 2020-01-16T20:42:51Z

frontend/public/components/catalog/catalog-items.tsx

add a type here

debsmita1 · 2020-01-16T20:43:59Z

frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts

remove the log statement

debsmita1 · 2020-01-17T19:47:53Z

please fix the lint error

abhinandan13jan · 2020-01-20T18:17:36Z

/test backend
/test e2e-gcp-console

debsmita1 · 2020-01-20T19:01:15Z

frontend/__tests__/components/catalog.spec.tsx

please fix the comments

debsmita1 · 2020-01-20T19:12:07Z

frontend/public/components/catalog/catalog-items.tsx

please write it like :

Suggested change

openOverlay(detailsItem: Item): void {

openOverlay = (detailsItem: Item): void => {

and get rid of this.openOverlay = this.openOverlay.bind(this);

debsmita1 · 2020-01-20T19:12:37Z

frontend/public/components/catalog/catalog-items.tsx

same as above

debsmita1 · 2020-01-20T19:12:58Z

frontend/public/components/catalog/catalog-items.tsx

same as above

christianvogt · 2020-01-21T02:51:22Z

frontend/public/components/catalog/catalog-items.tsx

Just FYI you don't need a type for assignments. Only when the right side is ambiguous like {...}

christianvogt · 2020-01-21T02:52:20Z

frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts

This change is unnecessary as you do not need a return statement for a single line function.

Yeah.... I console logged the csv and forgot to remove the {}.. will remove this

christianvogt · 2020-01-21T02:54:01Z

frontend/public/components/catalog/catalog-items.tsx

Same comment about assignment types.

christianvogt · 2020-01-21T02:56:04Z

frontend/public/components/catalog/catalog-items.tsx

Do these values end up in the url? They should probably be lower case be no spaces.

yes, they do... they cannot be case changes or altered directly as they need to be an exact string match with the annotation.

value: 'BasicInstall' || 'basicinstall' will not match with metadata.annotations.cabalities: Basic Install

Following the above recommendation, I am changing the vales to lowercase and also transforming the the capability data obtained from the CSV while adding it to the mock object
in dev-catalog.ts, line 59

debsmita1 · 2020-01-24T09:53:52Z

/lgtm

andrewballantyne · 2020-01-24T17:18:18Z

frontend/__tests__/components/catalog.spec.tsx

Think this needs a revert @abhinandan13jan

yes, reverted

Use dependecies from vendor dir Add goflag in build-backend backend: disable HTTP/2 Our proxy can't handle WebSockets when using HTTP/2. Increased height of activity card in overview dashboard Signed-off-by: Afreen Rahman <afrahman@redhat.com> add unit tests for ApplicationGroupResource refactor code refactor TopologyApplicationResource use isEmptyRender instead of exists simplify component Added helm chart repo proxy to the console backend All requests to `/api/helm/charts/*` are forwarded to the declared Helm chart repository. By default this is `https://redhat-developer.github.com/redhat-helm-charts`, but configurable via - `helm-chart-repo-url` CLI argument - BRIDGE_HELM_CHART_REPO_URL env variable - `config.yaml`: ``` . . . helm: chartRepository: url: https://foo.bar caFile: /path/to/cert.file ``` If needed, certificates for accessing the repo can be specified via `helm-chart-repo-ca-file` CLI arg, caFile config param, or using `BRIDGE_HELM_CHART_REPO_CA_FILE` env variable. If not specified, the system root CA will be used. Make extra step in VM Wizard to procceed trough Virtual Hardware tab Fix modal close on confirmation of a node regroup Add 4.4 channels bump formik - fixes enableReinitialize shared: make alert props optional in FormFooter shared: add basic methods and a method for adding multiple object keys to PatchBuilder Monitoring Dashboards: Change "Refresh Interval" options Change some of the "Refresh Interval" dropdown options and also add an option for switching auto-refresh off. adds monitoring metrics component and legend Custom pages added for noobaa chore: bump builder image dependencies * go 1.13 * node 13.6.0 * yarn 1.21.1 * kubectl 1.17.1 update table filter Add shadow on hover for topology decorators Initial boot order tests feat(topology-resourcemenu): add resource menu actions Allow children components on DetailsPage header Remove cluster operator upgrade activity BaremetalHost: Use new errorType field in Host CR When the operational status is in error, the BaremetalHost operator now reports the type of error from a fixed list. This is more reliable than determining the type of error from the provisioning status (e.g. a registration error may occur while the host is provisioning). The possible error types are registration, inspection, provisioning, and power management errors. There is no longer a validation error, and has not been for some time. Currently, there are actually separate provisioning states for each error type, so the Host would never have been in a Registering or Provisioning state after an error anyway, and this code would always have reported the host status as just 'error'. These separate states are being removed in favour of the separate errorType field. Since the existing code was not reachable, there is no need to keep it for backward compatibility with older versions of the operator. Signed-off-by: Zane Bitter <zbitter@redhat.com> make k8sPatch resilient to arrays with null values shared: move compareOwnerReferences from kubevirt enhance FirehoseResult type Add List component for detail properties This adds common component for lists in detail page properties. - Common styling - Semantic use of lists instead of spans and brs Add monitoring dashboard graph Refactoring: useReceiverFormStore and move single used functions out of utils add cpu pinning modal and functionality dashboards: initial support for table cards [metal3] Use HrefNavItem for BMH nav link This ensures that namespace is switched to 'openshift-machine-api' which is expected by BMO. This behaviour aligns with Machines namespace handling. Related Kubernetes issue: kubernetes/kubernetes#65551 kubevirt: enhance memory validation and template selection - unify and enhance template selections for validation and create requests - use GiB instead of GB for memory to allign with validations - show validation intervals Add the component and utility for helm release group initial implementation initial implementation remove styles for selected and fine tune initial implementation align the item to UX designs add tests for utility and update test use fill attribute istead of styles update snapshot add corner radius to helm icon refactor disable dnd for helm release node decrease opacity on filtered items fix llint error lint and destructuring Add edit application from deploy image Add unit tests for edit-application-utils Set image-stream values on populating the form with app data Fix bug wherein for image from internal registry new imagestream was created Change page title on Admin > Cluster Settings > Alertmanager Bug https://bugzilla.redhat.com/show_bug.cgi?id=1789946 Minor Enhancements for Stoarge Dashboards As per UXD suggestions, made these minor enhancements: * Fixed width of bar in breakdown card * Chnaging tab names * Spanning of lines to full width in utilization card * Linking of Nodes Changed ceph plugin gating from cephcluster model to storagecluster model Signed-off-by: Afreen Rahman <afrahman@redhat.com> ---------- Merged Pull request afreen23#1 ------------- Adding filter for nodes in ocs inventory Signed-off-by: Ankush Behl <cloudbehl@gmail.com> ------------------ Co-authored-by: Ankush Behl <cloudbehl@gmail.com> Reconcile feature flag extensions Clean up baremetal host states - Define bare metal host status and errors descriptions in constants - Pass status description as part of getBareMetalHostStatus helper - Simplify BareMetalHostStatus logic - Render status descriptions in status popovers - Render error status descriptions in status popover together with detailed error message - Remove unused bare metal host states Convert inline button to us isInline and proper spacing chore: bump node-sass to 4.13.1 Required for Node.js 13. add Deprovision action to Bare Metal Hosts Add clickable action to monitoring dashboard graph adds promQL editor and toggle option for it dashboard status: differentiate between unknown and not available states Add useExtensions hook & withExtensions HOC, use it for NavItem ext. Unify runtime handling of gated and always-on extensions Update login tests to work with either PF3 or PF4 login pages Added owners file to ceph and noobaa int Add support for Helm Install with release form and backend API Rename Overview pages to Details pages Rename Dashboards page to Overview Rename Overview Dashboard page to Cluster Add pause/unpause VM feature Monitoring Dashboards: Add currently displayed dashboard to URL Also changes the layout of the dropdown options to bring it closer to the mocks. Now clears any dashboard data as soon as the current dashboard is changed, so that all cards from the previous dashboard are immediately cleared. Added expand and upgrade activities in persistent storage dashboard Signed-off-by: Afreen Rahman <afrahman@redhat.com> All long string container names to wrap and add spacing to checkbox rows Monitoring Dashboards: Add graph legends Also includes some graph card style fixes to remove unnecessary margins and padding. kubevirt: fix modal footer padding kubevirt: Add RDP L2 integration test Configuration of nodes for the L2 network is out of scope (means bridge and DHCP server). A fake Windows VM (Fedora inside) is created, qemu-guest-agent installed, static IP address set to be later checked to verify the expected flow from the guest agent reporting to RDP console UI. Revert "chore: bump builder image dependencies" This reverts commit ef62018. chore: update to go 1.13 add ImageManifestVuln list/detail views Added installation flow for external cluster tracker track1 tracker1 tracker2 track2 tracker2 track trc trc

christianvogt · 2020-01-24T17:26:23Z

/lgtm
/approve

andrewballantyne

/lgtm

openshift-ci-robot · 2020-01-24T17:26:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, andrewballantyne, christianvogt, debsmita1, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-01-24T19:03:46Z

/retest

openshift-bot · 2020-01-24T19:47:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T20:38:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-01-24T20:47:52Z

/hold
for merge queue fix #4065

spadgett · 2020-01-25T04:25:03Z

/hold cancel
/retest

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/olm Related to OLM labels Jan 14, 2020

openshift-ci-robot requested review from jeff-phillips-18 and kyoto January 14, 2020 13:21

debsmita1 reviewed Jan 14, 2020

View reviewed changes

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2020

abhinandan13jan changed the title ~~[WIP]feat(dev-catalog): Add Capability level filters~~ feat(dev-catalog): Add Capability level filters Jan 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020

abhinandan13jan force-pushed the capability branch from 89403c6 to cd4e009 Compare January 16, 2020 13:18

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2020

abhinandan13jan changed the title ~~feat(dev-catalog): Add Capability level filters~~ [WIP]feat(dev-catalog): Add Capability level filters Jan 16, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020

debsmita1 reviewed Jan 16, 2020

View reviewed changes

abhinandan13jan force-pushed the capability branch from cd4e009 to 6f1a746 Compare January 17, 2020 09:38

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2020

abhinandan13jan force-pushed the capability branch from 6f1a746 to 9595bd0 Compare January 17, 2020 10:03

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2020

abhinandan13jan changed the title ~~[WIP]feat(dev-catalog): Add Capability level filters~~ feat(dev-catalog): Add Capability level filters Jan 17, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020

jeff-phillips-18 approved these changes Jan 17, 2020

View reviewed changes

abhinandan13jan force-pushed the capability branch from 9595bd0 to dedcbc7 Compare January 20, 2020 08:14

debsmita1 reviewed Jan 20, 2020

View reviewed changes

christianvogt reviewed Jan 21, 2020

View reviewed changes

abhinandan13jan changed the title ~~feat(dev-catalog): Add Capability level filters~~ [WIP]feat(dev-catalog): Add Capability level filters Jan 24, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2020

abhinandan13jan force-pushed the capability branch from 1b33915 to 2c3e5fa Compare January 24, 2020 07:28

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

abhinandan13jan changed the title ~~[WIP]feat(dev-catalog): Add Capability level filters~~ feat(dev-catalog): Add Capability level filters Jan 24, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2020

abhinandan13jan force-pushed the capability branch from 2c3e5fa to fef9505 Compare January 24, 2020 09:39

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

abhinandan13jan force-pushed the capability branch from fef9505 to eb1f94d Compare January 24, 2020 17:00

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

andrewballantyne reviewed Jan 24, 2020

View reviewed changes

abhinandan13jan force-pushed the capability branch from eb1f94d to 75899ca Compare January 24, 2020 17:25

openshift-ci-robot assigned christianvogt Jan 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

andrewballantyne approved these changes Jan 24, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Jan 24, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020

openshift-merge-robot merged commit dd15f71 into openshift:master Jan 25, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

	openOverlay(detailsItem: Item): void {
	openOverlay = (detailsItem: Item): void => {

feat(dev-catalog): Add Capability level filters #3952

feat(dev-catalog): Add Capability level filters #3952

Uh oh!

Conversation

abhinandan13jan commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewballantyne commented Jan 15, 2020

Uh oh!

debsmita1 commented Jan 16, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

debsmita1 commented Jan 17, 2020

Uh oh!

abhinandan13jan commented Jan 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinandan13jan Jan 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

debsmita1 commented Jan 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christianvogt commented Jan 24, 2020

Uh oh!

andrewballantyne left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

abhinandan13jan commented Jan 14, 2020 •

edited

Loading

abhinandan13jan Jan 21, 2020 •

edited

Loading