Skip to content

OLM: fix for single namespace monitoring checkbox #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 25, 2020
Merged

OLM: fix for single namespace monitoring checkbox #4061

openshift-merge-robot merged 1 commit into from
Jan 25, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 24, 2020

Correctly show the monitoring checkbox when an operator requests monitoring and the user switches to single namespace install mode.

Follow on bug fix for #3862. The selected namespace was incorrectly cleared when switching install modes.

/assign @benjaminapetersen

@spadgett
OLM: fix for single namespace monitoring checkbox
449b378 
Correctly show the monitoring checkbox when an operator requests
monitoring and the user switches to single namespace install mode.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2020
@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/retest

benjaminapetersen
benjaminapetersen approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

jhadvig
jhadvig approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Jan 24, 2020

/hold
for merge queue fix #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit c6ad570 into openshift:master Jan 25, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

+1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @openshift-bot @openshift-ci-robot @benjaminapetersen @jhadvig @openshift-merge-robot