Add Helm Release List Page #3960

rohitkrai03 · 2020-01-14T18:51:01Z

Related Story - https://issues.redhat.com/browse/ODC-2524

Depends on #3826 for the `/helm/list` API.

This PR -

Adds a new Nav Item for Helm Releases.
Adds new components - HelmReleasePage, HelmReleaseList, HelmReleaseHeader and HelmReleaseRow.
HelmReleaseList calls /helm/list API based on the namespace and Helm Release secrets fetch by firehose.
To minimize the number of API calls due to firehose resources chaning too often, adds a new utility for deep comparisons on dependencies in useEffect hook.
Adds custom text based filtering using TextFilter component from console.
Adds custom row filtering based on Helm Status using CheckBoxes component from console. The status based filtering also adds capability to filter multiplw statuses based on combined filter Other.

@openshift/team-devconsole-ux

Screencasts -

Helm Release List and Filtering -

Auto Update List -

rohitkrai03 · 2020-01-14T18:52:51Z

/assign @christianvogt

rohitkrai03 · 2020-01-14T19:17:27Z

Adding hold as it depends on #3826
/hold

rohitkrai03 · 2020-01-14T19:18:50Z

/test analyze

rohitkrai03 · 2020-01-14T20:13:37Z

/test analyze

andrewballantyne · 2020-01-15T01:29:00Z

/kind feature

frontend/packages/dev-console/src/components/helm/HelmReleaseRow.tsx

frontend/packages/dev-console/src/components/helm/HelmReleaseHeader.tsx

frontend/packages/dev-console/src/components/helm/helm-utils.ts

rohitkrai03 · 2020-01-16T20:37:31Z

/test analyze

serenamarie125

@rohitkrai03 nice job on this!

It feels like the page title/header has more white space than other pages, would you check that out, I might be wrong!

@sspeiche @siamaksade @sbose78 let's verify these are the appropriate columns. This is what we noted during our first meeting and is in the design, but we haven't talked much about it!

Can you also verify that these are the columns displayed during Search of a Helm Release?

Thanks!

akashshinde · 2020-01-20T08:25:54Z

frontend/packages/dev-console/src/components/helm/HelmReleaseList.tsx

@rohitkrai03 we've updated /api/console/helm/list API path to /api/helm/releases, please update here.

ref : https://github.com/openshift/console/blob/60ab162ca1f79d7c5780ed0adf8ef5b7a2da3e8c/pkg/server/server.go#L303

@akashshinde Sure.

Can you also update your PR description #3826 with new API endpoints?

rohitkrai03 · 2020-01-20T08:50:27Z

@rohitkrai03 nice job on this!

It feels like the page title/header has more white space than other pages, would you check that out, I might be wrong!

Maybe it seems like that because there is no Create button there. I've used same styles and classes from other pages so they should not differ.

divyanshiGupta · 2020-01-20T12:56:15Z

Please add unit tests.

rohitkrai03 · 2020-01-23T23:05:46Z

/retest

andrewballantyne · 2020-01-23T23:14:21Z

@rohitkrai03 you have an error that needs to be addressed:

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(162,9): Types of property 'componentProps' are incompatible.
  Type '{ name: string; href: string; required: FLAGS; testID: string; }' is not assignable to type '(Pick<NavLinkProps, "startsWith" | "name" | "testID"> & Pick<HrefLinkProps, "href" | "activePath">) | (Pick<NavLinkProps, "startsWith" | ... 1 more ... | "testID"> & Pick<...>) | (Pick<...> & Pick<...>)'.
    Object literal may only specify known properties, and 'required' does not exist in type '(Pick<NavLinkProps, "startsWith" | "name" | "testID"> & Pick<HrefLinkProps, "href" | "activePath">) | (Pick<NavLinkProps, "startsWith" | ... 1 more ... | "testID"> & Pick<...>) | (Pick<...> & Pick<...>)'.

andrewballantyne · 2020-01-23T23:19:03Z

/hold

Looks like the plugin type changed on you after you started.

andrewballantyne · 2020-01-23T23:23:05Z

frontend/packages/dev-console/src/plugin.tsx

Yup, looks like you need to remove this line.

Suggested change

required: FLAGS.OPENSHIFT,

rohitkrai03 · 2020-01-23T23:24:41Z

@andrewballantyne Updated the PR. the plugin SDK changes that went in after #3383 got merged was the issue. Missed that in huge CI logs.

andrewballantyne · 2020-01-23T23:24:48Z

/lgtm
/hold cancel

openshift-ci-robot · 2020-01-23T23:25:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, divyanshiGupta, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-01-23T23:25:37Z

@andrewballantyne Updated the PR. the plugin SDK changes that went in after #3383 got merged was the issue. Missed that in huge CI logs.

Aritra went to forum-ui and Sam responded... I saw what he looked for and it's just how I look for errors on "Docker Strategy Failed" now 😄

rohitkrai03 · 2020-01-24T00:03:28Z

/test analyze

openshift-bot · 2020-01-24T00:03:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rohitkrai03 · 2020-02-07T16:52:48Z

Hi, @rohitkrai03. Can you help us understand this change? It seems to be setting a bad filter value in redux and caused

https://bugzilla.redhat.com/show_bug.cgi?id=1798096

@spadgett The change was required for Helm List page. Helm Release is not a Kube resource so we needed to have custom filtering logic for the list page, and in order to re-use the CheckBoxes component for rendering RowFilters I needed a way to get the current filters and filter the releases. I figured out that the applyFilter prop can be used to pass a callback to the filtering logic in CheckBoxes component and get back the current filters. I was not aware of this side effect that it caused. Maybe we can change the prop name to applyCustomFilter to avoid the clash? Or if you see a better approach here please let me know. I can raise a PR for the fix.

spadgett · 2020-02-07T17:37:20Z

The one place I know of that used the checkboxes outside of a k8s resource list is the API explorer. It uses the CheckBoxControls component directly if that works here:

https://github.com/spadgett/console/blob/e7694b5cf06cb843ff2778deaea9b30417995bf9/frontend/public/components/api-explorer.tsx#L575-L599

Agree we should definitely avoid a name collision if there is one.

rohitkrai03 · 2020-02-07T18:03:56Z

The one place I know of that used the checkboxes outside of a k8s resource list is the API explorer. It uses the CheckBoxControls component directly if that works here:

https://github.com/spadgett/console/blob/e7694b5cf06cb843ff2778deaea9b30417995bf9/frontend/public/components/api-explorer.tsx#L575-L599

Agree we should definitely avoid a name collision if there is one.

Went through the code in API explorer and it seems like some logic is replicated from CheckBoxes component. Also, it doesn't have the ability to save the filter or update the URL params based on filter selection. I would prefer to update the prop name to applyCustomFilter and re-use all the functionalities that we get from CheckBoxes component. What do you think? If you're okay with it, I'll raise a quick PR for the change.

spadgett · 2020-02-07T18:05:44Z

I'm fine with that. Thanks for tracking this down.

rohitkrai03 · 2020-02-07T18:07:39Z

I'm fine with that. Thanks for tracking this down.

Great, so I'll raise a PR against this BZ https://bugzilla.redhat.com/show_bug.cgi?id=1798096

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2020

openshift-ci-robot requested review from christianvogt and jcaianirh January 14, 2020 18:51

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console labels Jan 14, 2020

openshift-ci-robot assigned christianvogt Jan 14, 2020

rohitkrai03 mentioned this pull request Jan 14, 2020

Add support for listing and installation of Helm Charts from Dev Catalog #3850

Merged

rohitkrai03 changed the title ~~Added Helm Release List Page and Nav Item for it~~ Add Helm Release List Page Jan 14, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2020

benjaminapetersen reviewed Jan 15, 2020

View reviewed changes

frontend/packages/dev-console/src/components/helm/HelmReleaseRow.tsx Outdated Show resolved Hide resolved

benjaminapetersen reviewed Jan 15, 2020

View reviewed changes

frontend/packages/dev-console/src/components/helm/HelmReleaseHeader.tsx Outdated Show resolved Hide resolved

benjaminapetersen reviewed Jan 15, 2020

View reviewed changes

frontend/packages/dev-console/src/components/helm/helm-utils.ts Outdated Show resolved Hide resolved

rohitkrai03 force-pushed the list-helm-releases branch from e3fc30d to 35f2d74 Compare January 16, 2020 12:52

serenamarie125 reviewed Jan 19, 2020

View reviewed changes

akashshinde reviewed Jan 20, 2020

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2020

rohitkrai03 force-pushed the list-helm-releases branch from 35f2d74 to 374aeac Compare January 20, 2020 10:14

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2020

rohitkrai03 force-pushed the list-helm-releases branch 2 times, most recently from bf08afa to 0836298 Compare January 20, 2020 12:10

openshift-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020

rohitkrai03 added 3 commits January 24, 2020 04:49

Added Helm Release List Page and Nav Item for it

761d849

Update backend API endpoint

c34e6d7

Added unit tests for utils

e13a78b

andrewballantyne reviewed Jan 23, 2020

View reviewed changes

Update plugin type

76aaefc

rohitkrai03 force-pushed the list-helm-releases branch from 3fa0224 to 76aaefc Compare January 23, 2020 23:23

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020

openshift-ci-robot assigned andrewballantyne Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-merge-robot merged commit ae6ccb5 into openshift:master Jan 24, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

rohitkrai03 deleted the list-helm-releases branch March 30, 2020 15:18

Add Helm Release List Page #3960

Add Helm Release List Page #3960

Uh oh!

Conversation

rohitkrai03 commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Story - https://issues.redhat.com/browse/ODC-2524

Depends on #3826 for the /helm/list API.

This PR -

Screencasts -

Helm Release List and Filtering -

Auto Update List -

Uh oh!

rohitkrai03 commented Jan 14, 2020

Uh oh!

rohitkrai03 commented Jan 14, 2020

Uh oh!

rohitkrai03 commented Jan 14, 2020

Uh oh!

rohitkrai03 commented Jan 14, 2020

Uh oh!

andrewballantyne commented Jan 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rohitkrai03 commented Jan 16, 2020

Uh oh!

serenamarie125 left a comment

Choose a reason for hiding this comment

Uh oh!

akashshinde Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

akashshinde Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 commented Jan 20, 2020

Uh oh!

divyanshiGupta commented Jan 20, 2020

Uh oh!

rohitkrai03 commented Jan 23, 2020

Uh oh!

andrewballantyne commented Jan 23, 2020

Uh oh!

andrewballantyne commented Jan 23, 2020

Uh oh!

andrewballantyne Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 commented Jan 23, 2020

Uh oh!

andrewballantyne commented Jan 23, 2020

Uh oh!

openshift-ci-robot commented Jan 23, 2020

Uh oh!

andrewballantyne commented Jan 23, 2020

Uh oh!

rohitkrai03 commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

rohitkrai03 commented Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett commented Feb 7, 2020

Uh oh!

rohitkrai03 commented Feb 7, 2020

Uh oh!

spadgett commented Feb 7, 2020

Uh oh!

rohitkrai03 commented Feb 7, 2020

Uh oh!

Reviewers

rohitkrai03 commented Jan 14, 2020 •

edited

Loading

Depends on #3826 for the `/helm/list` API.

rohitkrai03 commented Feb 7, 2020 •

edited

Loading