added monitoring tab with metrics section #3961

abhi-kn · 2020-01-14T19:17:34Z

Fixes:
https://issues.redhat.com/browse/ODC-2586

Analysis:
This US requires a monitoring tab to be displayed in topology side panel when a workload type resource is selected. Workload types supported in this PR are Deployment, DaemonSet & StatefulSet. Other type of workloads yet to be analysed w.r.t Prometheus support.

Solution Description:
Monitoring tab has been implemented in dev console & exposed through dev console plugin. Metrics section reuses MonitoringDashboardGraph component from /monitoring/dashboard to display graphs/plots. Prometheus queries used are yet to be reviewed by @christianvogt & Steve. Proposal doc for queries.
Note: post 4.4 feature freeze we would look into leveraging dashboard work done in console

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Unit test coverage report:

Browser conformance:

Chrome
Firefox
Safari
Edge

abhi-kn · 2020-01-14T19:18:11Z

/kind feature

abhi-kn · 2020-01-15T17:05:04Z

/assign @vikram-raj @invincibleJai

abhi-kn · 2020-01-16T13:43:17Z

/retest

vikram-raj · 2020-01-16T13:50:59Z

@abhi-kn Tests are failing because you didn't add my commit here. As it depends on this #3923

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx

frontend/public/components/overview/daemon-set-overview.tsx

frontend/packages/dev-console/src/plugin.tsx

frontend/public/components/overview/deployment-overview.tsx

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

abhi-kn · 2020-01-18T09:30:01Z

/retest

vikram-raj · 2020-01-21T07:14:50Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

I think the Gird layout is not needed here. Because anyway we are displaying a single graph in a row.

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

debsmita1 · 2020-01-21T07:34:58Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

one component per file please

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringSection.scss

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx

kyoto · 2020-01-22T07:22:52Z

frontend/packages/dev-console/src/components/monitoring/overview/queries.ts

/cc @openshift/openshift-team-monitoring

these seem pretty duplicate to the grafana dashboards we're embedding into the console, do we really want multiple pages that show the same data?

@brancz considering feature freeze in 2 days we decided to continue with pre-canned queries for now. Post that will take a spike to see how we can leverage dashboard work done for monitoring using configmaps for Grafna cc @abhi-kn

https://coreos.slack.com/archives/CR8NP36LT/p1579709940016100?thread_ts=1579709940.016100&cid=CR8NP36LT

kyoto · 2020-01-22T07:23:24Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardQueries.ts

/cc @openshift/openshift-team-monitoring

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx

christianvogt · 2020-01-23T01:23:28Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

Why a grid ? Seems like it's just stacking on top of each other. Also don't wrap single elements in a fragment.

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx

christianvogt · 2020-01-23T01:28:55Z

How often are we getting events that is causing the entire topology to rerender?
And how many events are being fetched in real world project?

christianvogt · 2020-01-23T01:30:06Z

/approve

invincibleJai · 2020-01-23T02:50:43Z

@christianvogt @abhi-kn have added below issues to track based on comments and showing just three visualization

cc @serenamarie125

updates extension support for sidebar

vikram-raj

\lgtm

vikram-raj

/lgtm

openshift-ci-robot · 2020-01-23T05:30:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-kn, christianvogt, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vikram-raj · 2020-01-23T05:30:28Z

/test analyze

openshift-bot · 2020-01-23T05:36:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2020

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2020

openshift-ci-robot requested review from andrewballantyne and benjaminapetersen January 14, 2020 19:20

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console labels Jan 14, 2020

openshift-ci-robot assigned invincibleJai and vikram-raj Jan 15, 2020

invincibleJai reviewed Jan 16, 2020

View reviewed changes

vikram-raj reviewed Jan 17, 2020

View reviewed changes

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetricsSection.tsx Outdated Show resolved Hide resolved

abhi-kn force-pushed the ODC-2586 branch 2 times, most recently from 2331822 to 6e823ff Compare January 17, 2020 19:44

openshift-ci-robot added the component/sdk Related to console-plugin-sdk label Jan 17, 2020

abhi-kn force-pushed the ODC-2586 branch from 6e823ff to ba4c98b Compare January 20, 2020 22:28

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2020

abhi-kn changed the title ~~[WIP] added monitoring tab with metrics section~~ added monitoring tab with metrics section Jan 20, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020

vikram-raj reviewed Jan 21, 2020

View reviewed changes

debsmita1 reviewed Jan 21, 2020

View reviewed changes

kyoto reviewed Jan 22, 2020

View reviewed changes

abhi-kn force-pushed the ODC-2586 branch from ba4c98b to b00e0bf Compare January 22, 2020 07:35

openshift-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2020

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2020

vikram-raj mentioned this pull request Jan 22, 2020

Add events and alerts to monitoring tab on overview page #4036

Merged

abhi-kn force-pushed the ODC-2586 branch from b00e0bf to 70a454c Compare January 22, 2020 11:43

openshift-ci-robot added the component/shared Related to console-shared label Jan 22, 2020

invincibleJai reviewed Jan 22, 2020

View reviewed changes

abhi-kn force-pushed the ODC-2586 branch from ab174c9 to 3780236 Compare January 22, 2020 18:26

christianvogt reviewed Jan 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020

added monitoring tab with metrics section.

0c1ca05

updates extension support for sidebar

abhi-kn force-pushed the ODC-2586 branch from 3780236 to 0c1ca05 Compare January 23, 2020 04:33

vikram-raj reviewed Jan 23, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-merge-robot merged commit 3607a4d into openshift:master Jan 23, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

invincibleJai mentioned this pull request Mar 5, 2020

Topology: Only retrieve events when showing the monitoring tab #4640

Merged

4 tasks

added monitoring tab with metrics section #3961

added monitoring tab with metrics section #3961

Uh oh!

Conversation

abhi-kn commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhi-kn commented Jan 14, 2020

Uh oh!

abhi-kn commented Jan 15, 2020

Uh oh!

abhi-kn commented Jan 16, 2020

Uh oh!

vikram-raj commented Jan 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abhi-kn commented Jan 18, 2020

Uh oh!

vikram-raj Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

debsmita1 Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyoto Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

brancz Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

invincibleJai Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyoto Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christianvogt Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

christianvogt commented Jan 23, 2020

Uh oh!

christianvogt commented Jan 23, 2020

Uh oh!

invincibleJai commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikram-raj left a comment

Choose a reason for hiding this comment

Uh oh!

vikram-raj left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 23, 2020

Uh oh!

vikram-raj commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

abhi-kn commented Jan 14, 2020 •

edited

Loading

invincibleJai Jan 22, 2020 •

edited

Loading

invincibleJai commented Jan 23, 2020 •

edited

Loading