Skip to content

chore: bump builder image dependencies #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 21, 2020
Merged

chore: bump builder image dependencies #3992

openshift-merge-robot merged 1 commit into from
Jan 21, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 17, 2020 •
edited
Loading

  • go 1.13
  • node 13.6.0
  • yarn 1.21.1
  • kubectl 1.17.1

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2020
@spadgett spadgett changed the title backend: update to go 1.12 [WIP] backend: update to go 1.12 Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2020
@spadgett spadgett mentioned this pull request Jan 17, 2020
Merged
@spadgett spadgett changed the title [WIP] backend: update to go 1.12 [WIP] backend: update to go 1.13 Jan 17, 2020
benjaminapetersen
benjaminapetersen approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@spadgett spadgett changed the title [WIP] backend: update to go 1.13 backend: update to go 1.13 Jan 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 17, 2020

/retest

@spadgett spadgett added this to the v4.4 milestone Jan 17, 2020
@spadgett spadgett added the area/dependency Issues or PRs related to dependency changes label Jan 17, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sbose78
Copy link

sbose78 commented Jan 17, 2020

Thanks!

@spadgett
Copy link
Member Author

spadgett commented Jan 17, 2020

@sbose78 sure thing. the pr you really need is openshift/release#6749. when that merges, you should be able to retest #3826

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2020
@spadgett spadgett changed the title backend: update to go 1.13 chore: bump builder image dependencies Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 20, 2020
@spadgett spadgett changed the title chore: bump builder image dependencies [WIP] chore: bump builder image dependencies Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2020
@spadgett spadgett changed the title [WIP] chore: bump builder image dependencies chore: bump builder image dependencies Jan 20, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020
benjaminapetersen
benjaminapetersen reviewed Jan 20, 2020
View reviewed changes
Dockerfile Outdated
Copy link
Contributor

@benjaminapetersen benjaminapetersen Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gonna note that this is:
https://quay.io/repository/coreos/tectonic-console-builder?tab=tags
Which we are manually building & pushing per convo, not CI.

benjaminapetersen
benjaminapetersen reviewed Jan 20, 2020
View reviewed changes
Dockerfile.builder Outdated
Copy link
Contributor

@benjaminapetersen benjaminapetersen Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./push-builder.sh requires a tag, we manually have to bump. Looks like we just increment by 1 ever time, nothing fancy. Prob no need to say more in this comment (I'm self documenting a bit while reviewing, since I haven't looked at this file in a while).

Copy link
Member Author

@spadgett spadgett Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the comment

benjaminapetersen
benjaminapetersen approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@spadgett
chore: bump builder image dependencies
ef62018 
* go 1.13
* node 13.6.0
* yarn 1.21.1
* kubectl 1.17.1
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 20, 2020

/lgtm

again, per the WIP removed.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Jan 20, 2020

/test backend

@spadgett
Copy link
Member Author

spadgett commented Jan 20, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 21, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit eed026d into openshift:master Jan 21, 2020
@spadgett spadgett deleted the go-1.12 branch January 21, 2020 14:15
@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed area/dependency Issues or PRs related to dependency changes labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@spadgett @openshift-bot @sbose78 @akashshinde @benjaminapetersen @openshift-ci-robot @openshift-merge-robot