Skip to content

console: update to tectonic-console-builder:v19 #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 18, 2020
Merged

console: update to tectonic-console-builder:v19 #6749

openshift-merge-robot merged 1 commit into from
Jan 18, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 17, 2020 •
edited
Loading

Bumps go to 1.13 for console builds

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 17, 2020

openshift/console#3992

benjaminapetersen
benjaminapetersen approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@spadgett spadgett changed the title [WIP] console: update to tectonic-console-builder:v19 console: update to tectonic-console-builder:v19 Jan 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 17, 2020

/assign @petr-muller
for approval

@spadgett spadgett mentioned this pull request Jan 17, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, petr-muller, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2020

@spadgett: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/console/master/e2e-gcp-console 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.4/analyze 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/master/images 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.5/analyze 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.5/e2e-gcp-console 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/master/frontend 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.4/images 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/master/backend 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.4/backend 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.5/backend 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.5/frontend 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.4/e2e-gcp-console 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.5/images 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/master/analyze 60f4fcb link /test pj-rehearse
ci/rehearse/openshift/console/release-4.4/frontend 60f4fcb link /test pj-rehearse
ci/prow/pj-rehearse 60f4fcb link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 29d90aa into openshift:master Jan 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2020

@spadgett: Updated the following 7 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • ci-operator-4.4-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-console-release-4.4.yaml using file ci-operator/config/openshift/console/openshift-console-release-4.4.yaml
  • ci-operator-4.4-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-console-release-4.4.yaml using file ci-operator/config/openshift/console/openshift-console-release-4.4.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-console-release-4.5.yaml using file ci-operator/config/openshift/console/openshift-console-release-4.5.yaml
  • ci-operator-4.5-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-console-release-4.5.yaml using file ci-operator/config/openshift/console/openshift-console-release-4.5.yaml
Details

In response to this:

Bumps go to 1.13 for console builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the tectonic-console-builder-v19 branch January 18, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

2 more reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @openshift-ci-robot @openshift-bot @benjaminapetersen @petr-muller @openshift-merge-robot