Skip to content

Conversation

@akashshinde
Copy link
Contributor

Why

go test and go vet downloads dependencies using go mod, since we already have deps in vendor dir this PR enables use of vendor deps.

This PR fixes test-backend.sh openshift-ci failure in #3826

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@sbose78
Copy link

sbose78 commented Jan 20, 2020

/test analyze

@spadgett spadgett added this to the v4.4 milestone Jan 20, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2020
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
For the moment to avoid retest of e2e-gcp-console, which is broken. I can manually override since the install completed successfully and it's a known flake.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@akashshinde
Copy link
Contributor Author

/test analyze

1 similar comment
@spadgett
Copy link
Member

/test analyze

@spadgett
Copy link
Member

/override e2e-gcp-console

The install completed successfully, and the tests failed on a known flake. Override to fix the broken backend tests.

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@spadgett
Copy link
Member

/override ci/prow/e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

@spadgett: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-gcp-console

Only the following contexts were expected:

  • ci/prow/analyze
  • ci/prow/backend
  • ci/prow/e2e-gcp-console
  • ci/prow/frontend
  • ci/prow/images
  • tide
Details

In response to this:

/override e2e-gcp-console

The install completed successfully, and the tests failed on a known flake. Override to fix the broken backend tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@spadgett: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-gcp-console

Only the following contexts were expected:

  • ci/prow/analyze
  • ci/prow/backend
  • ci/prow/e2e-gcp-console
  • ci/prow/frontend
  • ci/prow/images
  • tide
Details

In response to this:

/override e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/e2e-gcp-console

Details

In response to this:

/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 08b9543 into openshift:master Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

@akashshinde: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 9fcc599 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants