Move to useExtensions: Dashboards/Tab, Dashboards/Card #4054
Conversation
openshift-ci-robot
added
the
size/L
| }; | ||
|
|
||
| type UseExtensions = <E extends Extension>(typeGuard: ExtensionTypeGuard<E>) => readonly E[]; | ||
| type UseExtensions = <E extends Extension>(typeGuard: ExtensionTypeGuard<E>) => E[]; |
There was a problem hiding this comment.
FYI this change is to avoid TS errors like
The type 'readonly DashboardsTab[]' is 'readonly' and cannot be assigned to the mutable type 'DashboardsTab[]'.
since the readonly modifier actually yields a new type.
This isn't a big deal, though, since Console extension objects are frozen & immutable after their processing in PluginStore.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@vojtechszocs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Will add more commits to cover more extensions. |
openshift-ci-robot
added
the
do-not-merge/hold
2 participants
Use the new React friendly mechanism for consuming Console extensions:
Dashboards/TabDashboards/Cardcc @rawagner