Bug 1796626: fix create connector arrow head in topology #4063
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
component/dev-console
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
christianvogt
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@christianvogt: This pull request references Bugzilla bug 1796626, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@christianvogt: This pull request references Bugzilla bug 1796626, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@christianvogt: All pull requests linked via external trackers have merged. Bugzilla bug 1796626 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Fixes:
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1796626
Issue noticed during review of #3979
The connector line was switching between an arrowhead and the + marker. While hovering the empty space of the graph, it should always remain a + marker.
Analysis / Root cause:
Drop ref was referencing a group node which doesn't have a fixed size. The size of a group depends on the size of its children.
Solution Description:
Assign the drop ref to the background node which is a fixed size and always represents the background area of the visible graph.
Changes to popper are type fixes needed to get storybook to run again :(
Test setup:
yarn storybookhttp://localhost:6006/?path=/story/connector--create-connector
Browser conformance: