Bug 1803865: Fix to show Add popup only on graph and application groups #4342
Conversation
|
@jeff-phillips-18: This pull request references Bugzilla bug 1803865, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1803865, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
There was a problem hiding this comment.
This needs to be on this rect otherwise.
See PR #4063
There was a problem hiding this comment.
I think we should remove this altogether and set pointer-events: none on the handle so that we let whatever is underneath control the cursor.
There was a problem hiding this comment.
We do this in other scss files instead:
.odc-m-drag-active & {
cursor: grab;
}
But i think it should be:
&.is-dragging {
cursor: grab;
}
There was a problem hiding this comment.
The first is for when an item is being dragged, the second for when an item is dragged over an item (like a move/create connector) to avoid flicker should the cursor move off the dragged item momentarily.
|
/cherrypick release-4.4 |
|
@jeff-phillips-18: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@spadgett: This pull request references Bugzilla bug 1803865, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jeff-phillips-18
force-pushed
the
drag-validation
branch
from
fa645fe to
8f4ee26
Compare
jeff-phillips-18
force-pushed
the
drag-validation
branch
from
8f4ee26 to
764c4ca
Compare
Fix pointer flicker when dragging over nodes
jeff-phillips-18
force-pushed
the
drag-validation
branch
from
764c4ca to
6b78c36
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test analyze |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-gcp-console |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged. Bugzilla bug 1803865 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeff-phillips-18: new pull request created: #4453 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
Fixes:
Fixes https://issues.redhat.com/browse/ODC-2889
Fixes https://issues.redhat.com/browse/ODC-2221
Analysis / Root cause:
When dropping on an invalid target, the drop carried through to the graph or application group, prompting for the Add flow context menu.
Solution Description:
Add invalid targets as drop targets but set
canDropto return false. Use shallow check for drops on the graph and application groups that would result in the add context menu.Browser conformance:
/bug